Fixups and testing for cli config file parsing#722

Merged

motus merged 17 commits into

microsoft:mainfrom

bpkroth:launcher-test-args-fixups

Jul 23, 2024

bpkroth commented Mar 21, 2024

Contributor

Further fixups to #717

Some parameters were not being respected from --config test-cli-config.jsonc files.

Split out from #720

bpkroth added 2 commits

March 21, 2024 20:50


          Fixups and testing for cli config file parsing

f4b1348


          more tests

a08bf72

bpkroth marked this pull request as ready for review

March 21, 2024 20:58

bpkroth requested a review from a team as a code owner

March 21, 2024 20:58


          comments

0a22b78

bpkroth marked this pull request as draft

March 21, 2024 21:14

bpkroth added the WIP label

motus reviewed

View reviewed changes

mlos_bench/mlos_bench/launcher.py Outdated

mlos_bench/mlos_bench/tests/launcher_parse_args_test.py Outdated

mlos_bench/mlos_bench/tests/launcher_parse_args_test.py

bpkroth added 8 commits

April 29, 2024 17:52


          Merge branch 'main' into launcher-test-args-fixups

c64e0dc

wip

c09b427


          Merge branch 'main' into launcher-test-args-fixups

329bd18


          Merge remote-tracking branch 'upstream/main' into launcher-test-args-…

680d9a3

…fixups


          fixups

bcf05f9


          slurp some files from main

9023eb7


          apply formatters selectively

1f9f9c7


          Merge branch 'main' into launcher-test-args-fixups

e7cda08

bpkroth commented

View reviewed changes

mlos_bench/mlos_bench/launcher.py

bpkroth commented

View reviewed changes

mlos_bench/mlos_bench/launcher.py Outdated

bpkroth commented

View reviewed changes

mlos_bench/mlos_bench/launcher.py

bpkroth commented

View reviewed changes

mlos_bench/mlos_bench/launcher.py

bpkroth commented

View reviewed changes

mlos_bench/mlos_bench/optimizers/base_optimizer.py

bpkroth commented

View reviewed changes

mlos_bench/mlos_bench/schedulers/base_scheduler.py

bpkroth commented

View reviewed changes

mlos_bench/mlos_bench/schedulers/base_scheduler.py

bpkroth commented

View reviewed changes

mlos_bench/mlos_bench/tests/launcher_parse_args_test.py

bpkroth marked this pull request as ready for review

July 22, 2024 20:27


          fixups

2dee79f

motus requested changes

View reviewed changes

mlos_bench/mlos_bench/launcher.py

bpkroth added 3 commits

July 23, 2024 17:44


          apply comments


          Ignore negative config_id from the scheduler schema validation

f4e9c3f


          whitespace

70647dc

bpkroth added 2 commits

July 23, 2024 19:37


          revert unnecessary lineswap

4220aac


          remove comment

2dcffea

motus approved these changes

View reviewed changes

motus enabled auto-merge (squash)

July 23, 2024 21:21

motus disabled auto-merge

July 23, 2024 21:22

motus approved these changes

View reviewed changes

motus merged commit 7dce3d1 into microsoft:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WIP