Skip to content

Pluggable Scheduler#710

Merged
motus merged 45 commits into
microsoft:mainfrom
motus:sergiym/run/scheduler_load
Mar 15, 2024
Merged

Pluggable Scheduler#710
motus merged 45 commits into
microsoft:mainfrom
motus:sergiym/run/scheduler_load

Conversation

@motus

@motus motus commented Mar 9, 2024 •
edited by bpkroth
Loading

Copy link
Copy Markdown
Member
  • Make Scheduler class loadable from JSON configs
  • Update the Launcher and run.py to instantiate Scheduler from JSON
  • Create JSON schema for the Scheduler config
  • Add unit tests for the new Scheduler JSON configs

Closes #700

@motus motus added WIP Work in progress - do not merge yet mlos-bench labels Mar 9, 2024
@motus motus self-assigned this Mar 9, 2024
@motus motus marked this pull request as ready for review March 11, 2024 22:06
@motus motus requested a review from a team as a code owner March 11, 2024 22:06
@motus motus added the ready for review Ready for review label Mar 11, 2024
@motus motus removed the WIP Work in progress - do not merge yet label Mar 15, 2024
bpkroth
bpkroth reviewed Mar 15, 2024
View reviewed changes
Comment thread mlos_bench/mlos_bench/config/schemas/schedulers/scheduler-schema.json
bpkroth
bpkroth reviewed Mar 15, 2024
View reviewed changes
Comment thread mlos_bench/mlos_bench/launcher.py
bpkroth
bpkroth reviewed Mar 15, 2024
View reviewed changes
Comment thread mlos_bench/mlos_bench/launcher.py
bpkroth
bpkroth reviewed Mar 15, 2024
View reviewed changes
Comment thread mlos_bench/mlos_bench/launcher.py Outdated
bpkroth
bpkroth reviewed Mar 15, 2024
View reviewed changes
Comment thread mlos_bench/mlos_bench/launcher.py
motus and others added 2 commits March 15, 2024 13:27
@motus @bpkroth
Update mlos_bench/mlos_bench/launcher.py
8070c30 
Co-authored-by: Brian Kroth <bpkroth@users.noreply.github.com>
@bpkroth
pylint
f395531
@bpkroth bpkroth mentioned this pull request Mar 15, 2024
Open
bpkroth
bpkroth approved these changes Mar 15, 2024
View reviewed changes

@bpkroth bpkroth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@bpkroth bpkroth mentioned this pull request Mar 15, 2024
Closed
4 tasks
@motus motus merged commit 4166e96 into microsoft:main Mar 15, 2024
@motus motus deleted the sergiym/run/scheduler_load branch March 15, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@bpkroth bpkroth bpkroth approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@motus motus

Labels

mlos-bench ready for review Ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Config support for pluggable Schedulers

2 participants

@motus @bpkroth