Skip to content

Pluggable Scheduler implementation#691

Merged
bpkroth merged 50 commits into
microsoft:mainfrom
motus:sergiym/run/scheduler
Mar 7, 2024
Merged

Pluggable Scheduler implementation#691
bpkroth merged 50 commits into
microsoft:mainfrom
motus:sergiym/run/scheduler

Conversation

@motus

@motus motus commented Feb 28, 2024 •
edited by bpkroth
Loading

Copy link
Copy Markdown
Member

Initial implementation of a separate Scheduler class from the core run loop.

motus added 30 commits February 21, 2024 15:34
@motus
do not pass the optimizer into _run()
616f44e
@motus
mypy fixes
33e332a
@motus
start splitting the optimization loop into two
0247259
@motus
first complete version of the optimization loop (not tested yet)
483e378
@motus
Merge branch 'main' into sergiym/run/2loops
addd5a4
@motus
allow running mlos_bench.run._main directly from unit tests + add a u…
e97266f 
…nit test for bench (not tested)
@motus
move in-process launch to a separate unit test file
64771fd
@motus
add is_warm_up flag to the optimization step
bd7c55e
@motus
Merge branch 'main' of github.com:microsoft/MLOS into sergiym/run/2loops
387722a
@motus
in-process optimizaiton loop invocation works!
9f15aee
@motus
add multi-iteration optimization to in-process test; fix the mlos_cor…
65cd072 
…e bulk registration (check for is_warm_up)
@motus
make in-process launcerh tests pass
c010d95
@motus
remove unnecessary local variables to make pylint happy
7cfef3a
@motus
move trial_config_repeat_count checks to the launcher
7233180
@motus
make experiment.load() return trial_ids and use them in the optimizat…
be7dcec 
…ion loop
@motus
use proper last_trial_id in the main loop; fix the unit tests
3c52e03
@motus
update launcher tests with the new output patterns
0d9dc97
@motus
remove unused variable
4e171e0
@motus
Merge branch 'main' into sergiym/run/2loops
ab69fa0
@motus
better naming for functions in the optimization loop
52adab8
@motus
start implementing the scheduler class
df893d9
@motus
change the default value for is_warm_up parameter to False
5aca764
@motus
Merge branch 'sergiym/run/2loops' into sergiym/run/scheduler
4d183df
@motus
started to implement teh start() method of the sync scheduler
309e10c
@motus
Merge branch 'main' of github.com:microsoft/MLOS into sergiym/run/sch…
9a72b40 
…eduler
@motus
implement proper Scheduler constructor
ffe23e1
@motus
more clean-ups to the base scheduler
cb863e0
@motus
minor pylint fixes
990b019
@motus
add _add_trial_to_queue() method
2ac0520
@motus
better handling of warm-up phase (no redundant code)
b95100a
@motus motus marked this pull request as ready for review March 5, 2024 23:02
@motus motus requested a review from a team as a code owner March 5, 2024 23:02
@motus motus added the ready for review Ready for review label Mar 6, 2024
bpkroth
bpkroth approved these changes Mar 6, 2024
View reviewed changes

@bpkroth bpkroth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I can adapt what I had started for parallel workers pretty nicely for this. Thanks!

This was referenced Mar 6, 2024
Closed
Open
@bpkroth bpkroth changed the title Pluggable scheduler implementation - WIP Pluggable Scheduler implementation Mar 6, 2024
@bpkroth bpkroth removed the WIP Work in progress - do not merge yet label Mar 6, 2024
@bpkroth bpkroth enabled auto-merge (squash) March 6, 2024 23:05
@bpkroth bpkroth merged commit dd2547c into microsoft:main Mar 7, 2024
@motus motus deleted the sergiym/run/scheduler branch March 7, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@bpkroth bpkroth bpkroth approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@motus motus

Labels

mlos-bench ready for review Ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@motus @bpkroth