Skip to content

Initial work to separate the scheduler and the optimizer (no async yet)#684

Merged
motus merged 21 commits into
microsoft:mainfrom
motus:sergiym/run/2loops
Feb 27, 2024
Merged

Initial work to separate the scheduler and the optimizer (no async yet)#684
motus merged 21 commits into
microsoft:mainfrom
motus:sergiym/run/2loops

Conversation

@motus

@motus motus commented Feb 23, 2024 •
edited by bpkroth
Loading

Copy link
Copy Markdown
Member

Initial work to support pluggable Schedulers (#679).
This starts by adding the necessary support to auxiliary classes and splits the current simple run/optimize loop into two stages.
Future PRs will expand on this to separate abstract and configurable classes for more flexible scheduling policies.

@motus motus added enhancement New feature or request WIP Work in progress - do not merge yet mlos-bench labels Feb 23, 2024
@motus motus self-assigned this Feb 23, 2024
motus added 13 commits February 23, 2024 13:00
@motus
Merge branch 'main' into sergiym/run/2loops
addd5a4
@motus
allow running mlos_bench.run._main directly from unit tests + add a u…
e97266f 
…nit test for bench (not tested)
@motus
move in-process launch to a separate unit test file
64771fd
@motus
add is_warm_up flag to the optimization step
bd7c55e
@motus
Merge branch 'main' of github.com:microsoft/MLOS into sergiym/run/2loops
387722a
@motus
in-process optimizaiton loop invocation works!
9f15aee
@motus
add multi-iteration optimization to in-process test; fix the mlos_cor…
65cd072 
…e bulk registration (check for is_warm_up)
@motus
make in-process launcerh tests pass
c010d95
@motus
remove unnecessary local variables to make pylint happy
7cfef3a
@motus
move trial_config_repeat_count checks to the launcher
7233180
@motus
make experiment.load() return trial_ids and use them in the optimizat…
be7dcec 
…ion loop
@motus
use proper last_trial_id in the main loop; fix the unit tests
3c52e03
@motus
update launcher tests with the new output patterns
0d9dc97
@motus motus marked this pull request as ready for review February 24, 2024 01:14
@motus motus requested a review from a team as a code owner February 24, 2024 01:14
@motus motus added ready for review Ready for review and removed WIP Work in progress - do not merge yet labels Feb 24, 2024
bpkroth
bpkroth reviewed Feb 26, 2024
View reviewed changes
Comment thread mlos_bench/mlos_bench/optimizers/mlos_core_optimizer.py
bpkroth
bpkroth reviewed Feb 26, 2024
View reviewed changes
Comment thread mlos_bench/mlos_bench/run.py Outdated
bpkroth
bpkroth reviewed Feb 26, 2024
View reviewed changes
Comment thread mlos_bench/mlos_bench/run.py
bpkroth
bpkroth reviewed Feb 26, 2024
View reviewed changes
Comment thread mlos_bench/mlos_bench/run.py Outdated
bpkroth
bpkroth reviewed Feb 26, 2024
View reviewed changes
Comment thread mlos_bench/mlos_bench/run.py Outdated
bpkroth
bpkroth reviewed Feb 26, 2024
View reviewed changes
Comment thread mlos_bench/mlos_bench/run.py
bpkroth
bpkroth reviewed Feb 26, 2024
View reviewed changes
Comment thread mlos_bench/mlos_bench/run.py
@motus motus enabled auto-merge (squash) February 26, 2024 22:49
@bpkroth bpkroth changed the title Separate the scheduler and the optimizer (no async yet) Initial work to separate the scheduler and the optimizer (no async yet) Feb 26, 2024
bpkroth
bpkroth reviewed Feb 26, 2024
View reviewed changes
Comment thread mlos_bench/mlos_bench/optimizers/base_optimizer.py Outdated
bpkroth
bpkroth reviewed Feb 26, 2024
View reviewed changes
Comment thread mlos_bench/mlos_bench/tests/launcher_in_process_test.py
bpkroth
bpkroth approved these changes Feb 26, 2024
View reviewed changes

@bpkroth bpkroth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Looking forward to the expanded Scheduler classes

@motus motus merged commit 0127775 into microsoft:main Feb 27, 2024
@motus motus deleted the sergiym/run/2loops branch March 7, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@bpkroth bpkroth bpkroth approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@motus motus

Labels

enhancement New feature or request mlos-bench ready for review Ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@motus @bpkroth