Skip to content

Remove mistakenly added columns#652

Merged
motus merged 3 commits into
microsoft:mainfrom
bpkroth:mlos-bench/storage-schema-fixup
Jan 26, 2024
Merged

Remove mistakenly added columns#652
motus merged 3 commits into
microsoft:mainfrom
bpkroth:mlos-bench/storage-schema-fixup

Conversation

@bpkroth

@bpkroth bpkroth commented Jan 26, 2024

Copy link
Copy Markdown
Contributor

#628 mistakenly included an early attempt at adding optimization_target and optimization_direction to the experiment table in the mlos_bench.storage.sql backend.

In that PR we later moved it to its own objectives table to eventually support multi-objectives.

Nothing accesses those columns now, however including them in the metadata makes it impossible to load storage backends previously created with the old schema since adjusting columns with sqlalchemy's create_all() API only considers table existence.

On the contrary, the latter means that we will automatically support old storage backends with the new code for the objectives table.

Removing these two columns in the metadata schema description simply allows that to proceed without error.

See Also: #649

@bpkroth bpkroth requested a review from a team as a code owner January 26, 2024 18:20
@bpkroth bpkroth added bug Something isn't working ready for review Ready for review labels Jan 26, 2024
@motus motus enabled auto-merge (squash) January 26, 2024 22:55
@motus motus merged commit 5be96f2 into microsoft:main Jan 26, 2024
@bpkroth bpkroth deleted the mlos-bench/storage-schema-fixup branch February 27, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ready for review Ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants