Support for special tunable values outside of the range#617
Merged
Conversation
…values; implement TunableGroups to ConfigSpace conversion. TODO: convert from ConfigSpace back to Tunablegroups
bpkroth
reviewed
Jan 12, 2024
bpkroth
suggested changes
Jan 12, 2024
bpkroth
left a comment
bpkroth
left a comment
Contributor
There was a problem hiding this comment.
A few nits here and there, but I think the main thing we should revisit is whether to support mixed numerical and string types for special values.
bpkroth
reviewed
Jan 16, 2024
Co-authored-by: Brian Kroth <bpkroth@users.noreply.github.com>
Co-authored-by: Brian Kroth <bpkroth@users.noreply.github.com>
Co-authored-by: Brian Kroth <bpkroth@users.noreply.github.com>
…sergiym/tunable/special
bpkroth
reviewed
Jan 17, 2024
bpkroth
reviewed
Jan 17, 2024
bpkroth
reviewed
Jan 17, 2024
bpkroth
approved these changes
Jan 17, 2024
bpkroth
left a comment
bpkroth
left a comment
Contributor
There was a problem hiding this comment.
LGTM
I left one place to add a comment that probably needs some pylint checks for spacing.
I think one tweak we/I could add in a future PR would be to update the json schemas to account for disallowing ! characters in the names, but that doesn't have to be here.
Co-authored-by: Brian Kroth <bpkroth@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables special values outside of the range (e.g.,
-1with a range of[0, 100]).To do we make use of "conditionals" in ConfigSpace to constrain the space. This has a number of implementation implications, addressed below:
TunableclassTunableobjectsConfigSpaceconversionTunableGroupstoConfigSpaceconversion for tunables with special valuesmlos_coreoptimizers to support conditionals and special values inConfigSpaceConfigSpace