Skip to content

Expose IFeatureFilter - #29

Merged
Zhiyuan Liang (zhiyuanliang-ms) merged 1 commit into
mainfrom
zhiyuanliang/expose-IFeatureFilter
Aug 21, 2024
Merged

Expose IFeatureFilter#29
Zhiyuan Liang (zhiyuanliang-ms) merged 1 commit into
mainfrom
zhiyuanliang/expose-IFeatureFilter

Conversation

@zhiyuanliang-ms

@zhiyuanliang-ms Zhiyuan Liang (zhiyuanliang-ms) commented Aug 20, 2024

Copy link
Copy Markdown
Member

Why this PR?

IFeatureFilter should be exported so that users can implement customized feature filter.

@zhiyuanliang-ms Zhiyuan Liang (zhiyuanliang-ms) changed the title Expose i feature filter & Add .js extension to import file Expose IFeatureFilter & Add .js extension to import file Aug 20, 2024
@Eskibear

Copy link
Copy Markdown
Member

should separate into two PRs

  • export type
  • migrate to ESM style

@zhiyuanliang-ms
Zhiyuan Liang (zhiyuanliang-ms) force-pushed the zhiyuanliang/expose-IFeatureFilter branch from bae8389 to 6eae073 Compare August 20, 2024 08:37
@zhiyuanliang-ms Zhiyuan Liang (zhiyuanliang-ms) changed the title Expose IFeatureFilter & Add .js extension to import file Add .js extension to import file Aug 20, 2024
@zhiyuanliang-ms
Zhiyuan Liang (zhiyuanliang-ms) force-pushed the zhiyuanliang/expose-IFeatureFilter branch from 6eae073 to 779c01b Compare August 20, 2024 09:03
@zhiyuanliang-ms Zhiyuan Liang (zhiyuanliang-ms) changed the title Add .js extension to import file Expose IFeatureFilter Aug 20, 2024
@zhiyuanliang-ms
Zhiyuan Liang (zhiyuanliang-ms) deleted the zhiyuanliang/expose-IFeatureFilter branch August 21, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants