Fix parameter naming and add missing parameters in list_universal_snapshots - #485
Merged
Conversation
jbonzo
approved these changes
Aug 3, 2023
Collaborator
Author
|
Thanks for the speedy reviews @jbonzo ! Cheers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue reported in #476, where the
market_typeparameter was incorrectly named and several other parameters were missing in thelist_universal_snapshotsmethod of theSnapshotClientclass. The updates made in this PR align the code with the expected behavior and fixes a bug in universal snapshots retrieval by renaming themarket_typeparameter totypeand adding the missing parametersorder,limit, andsort. The corresponding example has also been updated to reflect these changes.