Skip to content

F/add phpmetrics#76

Merged
beporter merged 2 commits into
masterfrom
f/add-phpmetrics
Apr 12, 2016
Merged

F/add phpmetrics#76
beporter merged 2 commits into
masterfrom
f/add-phpmetrics

Conversation

@justinyost

Copy link
Copy Markdown
Contributor
  • Add PHPMetrics as a Composer Dependency
  • Add Script to run PHPMetrics and Generate Report (wrapper around ./bin/phpmetrics --report-html=./tmp/phpmetrics/index.html ./src)

@justinyost

Copy link
Copy Markdown
Contributor Author

@beporter if you want to take this to finish up the wrapper script feel free.

Signed-off-by: Justin Yost <justin@loadsys.com>
@beporter

Copy link
Copy Markdown
Contributor

Roger.

@beporter beporter added review and removed wip labels Apr 12, 2016
@beporter beporter assigned beporter and unassigned justinyost Apr 12, 2016
@beporter

Copy link
Copy Markdown
Contributor

Please give the new wrapper script a quick once-over. I'm failure FAIRLY sure it has no compile-time errors, but it's hard to test without manually installing the wrapper (and phpmetrics) into a project.

@justinyost

Copy link
Copy Markdown
Contributor Author

"failure sure" I love that.

@beporter

Copy link
Copy Markdown
Contributor

😛

@justinyost

Copy link
Copy Markdown
Contributor Author

Looks good here, to test for sure you could do a new branch in EU since there we are on dev-master of the shell scripts and just checkout this and such.

@beporter

Copy link
Copy Markdown
Contributor

We'll merge it and give it a shot. The nice thing about adding new scripts is that they don't have any effect on existing behavior, so you can have them in master and tweak them for a while before starting to depend on them.

@beporter beporter merged commit 9ab907c into master Apr 12, 2016
@beporter beporter deleted the f/add-phpmetrics branch April 12, 2016 15:40
@justinyost

Copy link
Copy Markdown
Contributor Author

Verified as working per other project.

@justinyost

Copy link
Copy Markdown
Contributor Author

I vote tag and release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants