Add -s option to codesniffer-run for "strict" mode.#72
Merged
Conversation
Reduces the warning threshold to make TODO marker warnings appear (now disabled by default in the Loadsys Coding Standard.) The -s flag can be used locally to review TODOs or in Travis builds to enforce their complete absence. Also enables color output by default.
Contributor
|
Do we want the default to be strict, and then explicitly change it for Travis? |
Contributor
Author
|
I'm thinking from the perspective of "the most typed case," which I believe is a developer running it locally. The |
Contributor
|
Ok, fair enough. |
Contributor
|
👍 |
beporter
added a commit
that referenced
this pull request
Feb 2, 2016
Add -s option to codesniffer-run for "strict" mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intent behind this change is to combat a general desensitization to sniff warnings. Issues are slipping past developers because they end up getting buried in a bunch of TODO warnings. We want to increase the signal to noise ratio while still making it straightforward to review the TODO markers via the code sniffer. loadsys/loadsys_codesniffer#50 reduces the default severity for TODO warnings to suppress them during normal runs. (The
-nswitch will continue to suppress all warnings.) The addition of the-s("strict") switch in this PR will reduce the warning threshold to make TODO marker warnings appear in the output.The
-sflag can be used locally to review TODOs or in Travis builds to enforce their complete absence.Also enables color output by default.