This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 22843 ]] Implement modal/sheet without waiting#7404
Open
montegoulding wants to merge 7 commits intolivecode:developfrom
Open
[[ Bug 22843 ]] Implement modal/sheet without waiting#7404montegoulding wants to merge 7 commits intolivecode:developfrom
montegoulding wants to merge 7 commits intolivecode:developfrom
Conversation
This patch ensures if `MCPlatformWaitForEvent` will return true if either it found an event in the specified time or it ran a modal session which will trigger event handling for the target window.
This patch adds the `without waiting` clause to the modal and sheet subwindow commands.
This patch adds the `without waiting` clause to the go as modal and sheet commands.
This patch adds a parameter to `MCStack::openrect` to wait while opening. This param replaces the previous implicit wait while opening behavior when the window mode was modal or sheet.
This patch adds a release note for the new `without waiting` clause in the `modal`, `sheet` and `go` commands.
This patch updates the `go`, `modal` and `sheet` commands to document the new `without waiting` clause for modal and sheet dialog boxes.
This patch adds test for the subwindow without waiting clause.
montegoulding
force-pushed
the
bugfix-22843
branch
from
c9fa6a3 to
b7d2d6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch implements:
{modal | sheet} <stack> without waitingandgo <stack> as {modal | sheet} without waiting