Conversation
Closed
doits
reviewed
Jan 27, 2020
doits
reviewed
Jan 27, 2020
doits
reviewed
Jan 27, 2020
Contributor
|
Just my two cents: 👍 for removing it, I think that this should not be part of the library either. |
Collaborator
Author
|
Thanks @doits, I forgot to update the documentation, will do! |
|
@stas Is this good to be merged? |
Collaborator
Author
|
@oyeanuj yep, I should merge it, was trying to orchestrate it a bit together with other updates... |
Collaborator
Author
|
Merged into the wrong branch, so I updated it manually... 🙈 |
nicbet
reviewed
Jun 18, 2020
nicbet
reviewed
Jun 18, 2020
nicbet
reviewed
Jun 18, 2020
|
Was hit by the Deprecation warning today, tried to follow changes in README and hit some issues. I left comments on the PR commit code where things are amiss. |
Collaborator
Author
|
Thanks @nicbet, but this is long ago fixed on master. In future, could you please open a separate issue, it's a bit hard to follow the conversations after the PRs are merged. 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First steps to completely remove the out-of-the-box JSON serialization support.
I added an example how to achieve the same old API functionality.
This should close #12
Thanks to @ThomasSevestre and @christophersansone for helping with this!