Adding migration section - #139
Conversation
|
Thanks @guillaumebriday, this is great! 🙇♂️ I don't recall anything else (maybe the cache support changes https://github.com/jsonapi-serializer/jsonapi-serializer/pull/52/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5) But I'm happy to merge this as the first step. Let me know if it's ready @guillaumebriday |
|
Nice catch, will add it. Any other suggestion? 🤔 |
|
My 'base_serializer.rb' file has a line:
Might be obvious to most, but maybe mention changing it to: |
|
thanks @tonydehnke I don't need |
|
I think it's ready now 👍 |
|
Hi all, I'm not sure if this is the right place to ask, so let me know and I'll be happy to move this question. I tried migrating from Which used to work, but stopped working after migration to As the error indicates, I don't have an |
|
Hey @jrochette We had previous reports related to this change, one of them here: Would you be kind to take a look at it and let me know if that makes any sense?! In a nutshell, you might need to specify the serializer inline if it doesn't follow a conventional naming pattern. |
|
Hey @stas Thanks for the quick response. I looked at #151 and I don't think it is the same issue, but the explanation does make sense. I agree that it's a good idea to make the serializer resolving rely less on magic. Just to put more context, I my case, it is not that the serializer is not resolved because of a namespace issue. It doesn't get resolved because it does not exist. I assume there was a mechanism in We have put our migration to |
That's actually excluded. What could have been the case is that you'd get another/wrong serializer class doing the serialization for you. Good luck! |
What is the new behavior?
Trying to help people to migrate from Netlflix/fast_jsonapi.
Did I forget something ?