Delete methods deprecated prior to JRuby 9.4.0.0#9299
Merged
headius merged 12 commits intojruby:masterfrom Mar 11, 2026
Merged
Conversation
There's a few places where methods were deprecated but superclass or interface versions were not. Those will have to wait until all versions have been deprecated for some time. Others had interface or abstract methods that were deprecated some time ago but the implementations were deprecated in 9.4.x. Those have generally been deleted. A few places that reflectively access deprecated methods have been documented and the original method remains in place. There are also several places where methods were deprecated but no suitable replacement is available, and they are still in use with SuppressWarnings. We will need to audit all SuppressWarnings and either find suitable replacements or un-deprecated.
jruby-openssl still builds against an older JRuby that uses these deprecated signatures. It will need to be rebuilt with a newer JRuby once we have decided to abandon those older versions. The "pre" methods are also still used by these older forms, so they are restored here.
jruby-openssl still uses this older blocking task API. It will need to be updated to a newer API that is available on all the JRuby versions it supports.
headius
force-pushed
the
delete_deprecated
branch
from
928b38c to
bb1c8a8
Compare
Not intended to be removed. memchr at least is still used by StringIO.
Deprecated and removed.
headius
force-pushed
the
delete_deprecated
branch
from
bb1c8a8 to
6d6abba
Compare
This was referenced Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a few places where methods were deprecated but superclass or interface versions were not. Those will have to wait until all versions have been deprecated for some time.
Others had interface or abstract methods that were deprecated some time ago but the implementations were deprecated in 9.4.x. Those have generally been deleted.
A few places that reflectively access deprecated methods have been documented and the original method remains in place.
There are also several places where methods were deprecated but no suitable replacement is available, and they are still in use with SuppressWarnings. We will need to audit all SuppressWarnings and either find suitable replacements or un-deprecated.