401K_Support - #21
Merged
Merged
Conversation
nimisha84
approved these changes
Aug 7, 2020
nimisha84
left a comment
nimisha84
left a comment
There was a problem hiding this comment.
Make sure you add overload func to accept auth urls directly too in case discovery call fails for some reason. Other then that, looks good
Contributor
Author
@nimisha84 : Created a new helper method setAuthorizeURLs to have the ability to pass in the custom authorization URLs as a dictionary. |
|
def get_authorization_url(self, scopes, state_token=None): I see this uses enum scopes to build the authorization url. Can you add an overload to accept the string scopes as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for 401k use case. Changes added :
1.)
setAuthorizeURLshelper function to pass custom auth URL's2.) Payslip Enum added
3.) Utils modification to handle any custom discovery doc URL's passed as plain string
4.) version change to
1.2.4