fix: restoring umd format#17
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 52 52
Lines 1352 1352
Branches 191 191
=========================================
Hits 1352 1352 Continue to review full report at Codecov.
|
anandtiwary
reviewed
Jul 16, 2020
| @@ -1,4 +1,5 @@ | |||
| // tslint:disable | |||
| import { camelCase } from 'lodash'; | |||
There was a problem hiding this comment.
other imports from 'lodash-es' should also be reverted right?
Contributor
Author
There was a problem hiding this comment.
nope, not actually reverting lodash-es, just adding the umd module back as well. This one runs as part of rollup so is running in node and needs the commonjs format.
anandtiwary
approved these changes
Jul 16, 2020
|
🎉 This PR is included in version 1.1.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.