refactor: use pointer receivers on all scpUploadState methods - #366
Open
tenthirtyam wants to merge 1 commit into
Open
tenthirtyam wants to merge 1 commit into
tenthirtyam wants to merge 1 commit into
Conversation
Both `DestPath` and `SrcPath` methods were the only methods on `scpUploadState` that used a value receiver. They only read fields, so behavior does not change. The other methods already use a pointer because they update the session. Using the same receiver on every method avoids mixing styles and makes it clear these helpers run on the same state, not a copy. Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the method receivers for
DestPathandSrcPathin thescpUploadStatestruct to use pointer receivers instead of value receivers. This change ensures consistency and allows these methods to work correctly if the struct is modified in the future. No other significant logic changes are introduced.Both
DestPathandSrcPathmethods were the only methods onscpUploadStatethat used a value receiver. They only read fields, so behavior does not change. The other methods already use a pointer because they update the session. Using the same receiver on every method avoids mixing styles and makes it clear these helpers run on the same state, not a copy.Rollback Plan
Revert commit.
Changes to Security Controls
None.