Skip to content

add support for valid values for (de)Humidifier target state #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ccutrer merged 4 commits into from
Dec 7, 2020
Merged

add support for valid values for (de)Humidifier target state #120

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2aa7769
[#119] added support for valid values for target HumidifierDehumidifi…
gjvanderheiden Dec 5, 2020
5a58bfa
[#119] added support for valid values for target HumidifierDehumidifi…
gjvanderheiden Dec 5, 2020
b9d11b7
[#119] added support for valid values for target HumidifierDehumidifi…
gjvanderheiden Dec 5, 2020
32c5159
[#119] added support for valid values for target HumidifierDehumidifi…
gjvanderheiden Dec 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[#119] added support for valid values for target HumidifierDehumidifi… 
…erState
  • Loading branch information
@gjvanderheiden
gjvanderheiden committed Dec 5, 2020
commit 5a58bfab104ae00eba313d919162d6f361c5fdee
10 changes: 10 additions & 0 deletions src/main/java/io/github/hapjava/accessories/HumidifierDehumidifierAccessory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,16 @@ public interface HumidifierDehumidifierAccessory extends HomekitAccessory {
CompletableFuture<Void> setTargetHumidifierDehumidifierState(
TargetHumidifierDehumidifierStateEnum state);

/**
* Valid values for target state.
*
* @return array of valid target states.
*/
default TargetHumidifierDehumidifierStateEnum[]
getTargetHumidifierDehumidifierStateValidValues() {
return TargetHumidifierDehumidifierStateEnum.values();
}

/**
* Subscribes to changes in the humidifier/dehumidifier current state.
*
Expand Down
3 changes: 2 additions & 1 deletion ...java/characteristics/impl/humidifier/TargetHumidifierDehumidifierStateCharacteristic.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,15 @@ public class TargetHumidifierDehumidifierStateCharacteristic
implements EventableCharacteristic {

public TargetHumidifierDehumidifierStateCharacteristic(
TargetHumidifierDehumidifierStateEnum[] validValues,
Supplier<CompletableFuture<TargetHumidifierDehumidifierStateEnum>> getter,
ExceptionalConsumer<TargetHumidifierDehumidifierStateEnum> setter,
Consumer<HomekitCharacteristicChangeCallback> subscriber,
Runnable unsubscriber) {
super(
"000000B4-0000-1000-8000-0026BB765291",
"target humidifier state",
TargetHumidifierDehumidifierStateEnum.values(),
validValues,
Optional.of(getter),
Optional.of(setter),
Optional.of(subscriber),
Expand Down
1 change: 1 addition & 0 deletions src/main/java/io/github/hapjava/services/impl/HumidifierDehumidifierService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ public HumidifierDehumidifierService(HumidifierDehumidifierAccessory accessory)
accessory::subscribeCurrentHumidifierDehumidifierState,
accessory::unsubscribeCurrentHumidifierDehumidifierState),
new TargetHumidifierDehumidifierStateCharacteristic(
accessory.getTargetHumidifierDehumidifierStateValidValues(),
accessory::getTargetHumidifierDehumidifierState,
accessory::setTargetHumidifierDehumidifierState,
accessory::subscribeTargetHumidifierDehumidifierState,
Expand Down