Fix #1413 IC3 carried-row reentry#1428
Open
lmeyerov wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WITH person, collect(city) AS cities MATCH ...WITHstages for the single-reentry IC3 suffixNOT friendCity IN citiesRETURN n, collect(x)in the validation-failure bucket until optional null filtering is supportedcollect(city),collect(DISTINCT city), CASE aggregation, post-aggregate filtering, TCK optional aggregate boundary, and cuDF reentry smokeValidation
PYTHONPATH=/tmp/pygraphistry-issue-1413-deps python3 -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k 'issue_1413_ic3 or optional_match_collect_null_whole_row_return_boundary or optional_match_collect_alias_property or optional_match_collect_case_relationship_rows or failfast_relationship_whole_row_grouped_count_star_boundary'-> 6 passedPYTHONPATH=/tmp/pygraphistry-issue-1413-deps python3 -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k '(issue_1413 or multi_alias_with_distinct_scalar_projection or graph_backed_unwind_after_with or post_with_match_collect_unwind_match or multi_stage_with_match_reentry or aggregate_whole_row or collect_alias_property or optional_match_collect_null_whole_row_return_boundary) and not cudf'-> 23 passedPYTHONPATH=/tmp/pygraphistry-issue-1413-deps python3 -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k 'not cudf'-> 896 passed, 12 skippedPYTHONPATH=/home/lmeyerov/Work/pygraphistry2:/tmp/tck-gfql-f02d17c:/tmp/pygraphistry-issue-1413-deps python3 -m pytest -q tests/cypher_tck/test_tck_runner.py::test_direct_cypher_xfail_contract --tb=short-> 783 passedpython3 -m ruff check ...-> passedPYTHONPATH=/tmp/pygraphistry-issue-1413-deps python3 -m py_compile ...-> passedPYTHONPATH=/tmp/pygraphistry-issue-1413-deps python3 bin/ci_cypher_surface_guard.py-> passedgit diff --check-> passedMATRIX_CELLS="25.02:gfql 26.02:gfql" WITH_IMAGE_BUILD=0 WITH_GPU=1 WITH_LINT=0 WITH_TYPECHECK=0 WITH_TEST=1 PROFILE=gfql TEST_FILES="..." ./test-rapids-official-matrix.sh-> 25.02/gfql PASS, 26.02/gfql PASSf111dac4-> green, including duplicatedtck-gfqlNotes