Skip to content

Expose 'Blob.kms_key_name' as read-only property#5249

Merged
tseaver merged 2 commits into
storage-support_kms_keys-wipfrom
storage-support_kms_keys-kms_key_from_repr
Apr 27, 2018
Merged

Expose 'Blob.kms_key_name' as read-only property#5249
tseaver merged 2 commits into
storage-support_kms_keys-wipfrom
storage-support_kms_keys-kms_key_from_repr

Conversation

@tseaver
Copy link
Copy Markdown
Contributor

@tseaver tseaver commented Apr 26, 2018

Backed by _properties.

@tseaver tseaver added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: storage Issues related to the Cloud Storage API. labels Apr 26, 2018
@tseaver tseaver requested review from frankyn and theacodes April 26, 2018 22:50
@tseaver tseaver requested a review from lukesneeringer as a code owner April 26, 2018 22:50
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 26, 2018
@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented Apr 27, 2018

@frankyn PTAL

@frankyn
Copy link
Copy Markdown
Contributor

frankyn commented Apr 27, 2018

@tseaver review now.

frankyn
frankyn reviewed Apr 27, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raising some more context:

kms_key_name can be updated in a objects.rewrite even. I don't think this will cause an issue given the existing key rotation surface, and want to make sure it's still possible.

@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented Apr 27, 2018

Creating a destination key w/ kms_key_name allows rewrite to set / rotate the key for an existing blob.

@tseaver tseaver merged commit a93427c into storage-support_kms_keys-wip Apr 27, 2018
@tseaver tseaver deleted the storage-support_kms_keys-kms_key_from_repr branch April 27, 2018 18:26
tseaver added a commit that referenced this pull request May 9, 2018
@tseaver
Expose 'Blob.kms_key_name' as read-only property (#5249)
16c5f86 
Backed by '_properties'.
tseaver added a commit that referenced this pull request May 9, 2018
@tseaver
Storage: add support for KMS keys (#5259)
38c3e9a 
* Add support for blob-level KMS encryption keys (#5221)

* Add 'Bucket.default_kms_key_name' property. (#5222)

* Expose 'Blob.kms_key_name' as read-only property (#5249)

* Add system tests for GCS-KMS integration (#5257)
parthea pushed a commit that referenced this pull request Mar 9, 2026
@tseaver
Storage: add support for KMS keys (#5259)
592ca82 
* Add support for blob-level KMS encryption keys (#5221)

* Add 'Bucket.default_kms_key_name' property. (#5222)

* Expose 'Blob.kms_key_name' as read-only property (#5249)

* Add system tests for GCS-KMS integration (#5257)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

2 more reviewers

@frankyn frankyn frankyn left review comments

@theacodes theacodes theacodes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tseaver @frankyn @theacodes @googlebot