Skip to content

Allow directly passing force to ConfigClient.delete_deployment()#13840

Closed
jhollowe wants to merge 1 commit into
googleapis:mainfrom
jhollowe:main
Closed

Allow directly passing force to ConfigClient.delete_deployment()#13840
jhollowe wants to merge 1 commit into
googleapis:mainfrom
jhollowe:main

Conversation

@jhollowe
Copy link
Copy Markdown

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #13839 🦕

@jhollowe jhollowe requested a review from a team April 24, 2025 20:01
@google-cla
Copy link
Copy Markdown

google-cla Bot commented Apr 24, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jhollowe jhollowe changed the title Allow directly passing force to ConfigClient().delete_deployment() Allow directly passing force to ConfigClient.delete_deployment() Apr 25, 2025
@vchudnov-g
Copy link
Copy Markdown
Contributor

Thanks for your PR! However, this package, like most packages in this repo, is auto-generated, so your changes would be overwritten when there's an API update. If our libraries are not being generated with some needed functionality, could you file an issue detailing what's needed?

Thank you!

@parthea
Copy link
Copy Markdown
Contributor

parthea commented Apr 29, 2025

Closing as per #13840 (comment)

We will follow up on #13839

@parthea parthea closed this Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[config] Allow directly passing force to ConfigClient.delete_deployment()

3 participants