Block insecure non-multi options in clone/clone_from#1609
Merged
Byron merged 1 commit intogitpython-developers:mainfrom Jul 10, 2023
Beuc:block-insecure-options-clone-non-multi
Merged
Block insecure non-multi options in clone/clone_from#1609Byron merged 1 commit intogitpython-developers:mainfrom Beuc:block-insecure-options-clone-non-multi
Byron merged 1 commit intogitpython-developers:mainfrom
Beuc:block-insecure-options-clone-non-multi
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm part of the Debian LTS (Long Term Support) Team and I'm working on integrating the fix for CVE-2022-24439 for GitPython in Debian.
After contacting @Byron privately we determined that #1521 would need a follow-up fix, which I hereby propose in this PR.
I also modified 2 tests to validate the change, but I'm not sure if we want to double-check (multi/non-multi) all the currenttt clone/clone_from tests, so I didn't, but I can do so if necessary.