Merged
Conversation
gdubicki
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
gdubicki
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v5 #960 +/- ##
=======================================
Coverage 87.00% 87.00%
=======================================
Files 73 73
Lines 3802 3802
=======================================
Hits 3308 3308
Misses 494 494
🚀 New features to boost your workflow:
|
gdubicki
force-pushed
the
tweak-docker-image
branch
from
42b4dd1 to
217e58a
Compare
gdubicki
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
gdubicki
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
amimas
reviewed
Feb 18, 2025
Collaborator
amimas
left a comment
amimas
left a comment
There was a problem hiding this comment.
Haven't tried this out myself yet. Left a few comments to consider.
Collaborator
amimas
force-pushed
the
v5
branch
2 times, most recently
from
60223b0 to
a98261b
Compare
(if you would ever do this) thanks to not adding to it any files that are not really needed, but may exist on a development machine
thanks to not creating pip cache (really) and not installing seemingly unneeded APK packages
The change also updates dockerignore file ignoring more files from build context
amimas
force-pushed
the
tweak-docker-image
branch
from
217e58a to
c460483
Compare
amimas
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
amimas
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
Collaborator
|
@gdubicki @TimKnight01 - Picked this up and rebased and pushed an update to it. My update mainly introduces multi-stage builds. Here's what image size looks like with various versions. Here you can see our current released version (v4.8.0) image size is 88.5MB. Original update from this PR reduced it down to 77.1MB. With the multi-stage docker build, it can come down to 68.5MB. Let me know if you see any issues or concerns. Otherwise, let's get this in for v5 release. |
TimKnight01
approved these changes
Feb 16, 2026
Collaborator
|
@amimas looks good - I'll merge into V5 and do a test of v5 against a Gitlab repo somewhere |
TimKnight01
pushed a commit
that referenced
this pull request
Feb 16, 2026
* build: faster building and smaller image locally (if you would ever do this) thanks to not adding to it any files that are not really needed, but may exist on a development machine * build: ~10MB (~11%) smaller image (numbers for ARM64) thanks to not creating pip cache (really) and not installing seemingly unneeded APK packages * build: we only need types packages for development * style: re-arrange dev dependencies in alphabetical order * fix: restore copy command so that docker build works * feat: use multi-stage dockerfile to reduce image size The change also updates dockerignore file ignoring more files from build context --------- Co-authored-by: amimas <aver.mimas@gmail.com>
TimKnight01
pushed a commit
that referenced
this pull request
Feb 16, 2026
* build: faster building and smaller image locally (if you would ever do this) thanks to not adding to it any files that are not really needed, but may exist on a development machine * build: ~10MB (~11%) smaller image (numbers for ARM64) thanks to not creating pip cache (really) and not installing seemingly unneeded APK packages * build: we only need types packages for development * style: re-arrange dev dependencies in alphabetical order * fix: restore copy command so that docker build works * feat: use multi-stage dockerfile to reduce image size The change also updates dockerignore file ignoring more files from build context --------- Co-authored-by: amimas <aver.mimas@gmail.com>
TimKnight01
pushed a commit
that referenced
this pull request
Feb 16, 2026
* build: faster building and smaller image locally (if you would ever do this) thanks to not adding to it any files that are not really needed, but may exist on a development machine * build: ~10MB (~11%) smaller image (numbers for ARM64) thanks to not creating pip cache (really) and not installing seemingly unneeded APK packages * build: we only need types packages for development * style: re-arrange dev dependencies in alphabetical order * fix: restore copy command so that docker build works * feat: use multi-stage dockerfile to reduce image size The change also updates dockerignore file ignoring more files from build context --------- Co-authored-by: amimas <aver.mimas@gmail.com>
TimKnight01
pushed a commit
that referenced
this pull request
Mar 12, 2026
* build: faster building and smaller image locally (if you would ever do this) thanks to not adding to it any files that are not really needed, but may exist on a development machine * build: ~10MB (~11%) smaller image (numbers for ARM64) thanks to not creating pip cache (really) and not installing seemingly unneeded APK packages * build: we only need types packages for development * style: re-arrange dev dependencies in alphabetical order * fix: restore copy command so that docker build works * feat: use multi-stage dockerfile to reduce image size The change also updates dockerignore file ignoring more files from build context --------- Co-authored-by: amimas <aver.mimas@gmail.com>
amimas
added a commit
that referenced
this pull request
Mar 13, 2026
* build: faster building and smaller image locally (if you would ever do this) thanks to not adding to it any files that are not really needed, but may exist on a development machine * build: ~10MB (~11%) smaller image (numbers for ARM64) thanks to not creating pip cache (really) and not installing seemingly unneeded APK packages * build: we only need types packages for development * style: re-arrange dev dependencies in alphabetical order * fix: restore copy command so that docker build works * feat: use multi-stage dockerfile to reduce image size The change also updates dockerignore file ignoring more files from build context --------- Co-authored-by: amimas <aver.mimas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
But I have tiny doubts about whether the created image works. 😅 I mean: the app definitely runs, but I wonder if something will not fail when actually using some of its features.