Skip to content

basen: decouple normalization proof from cbase32 #1717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sergey-shandar merged 5 commits into from
Aug 26, 2026
Merged

basen: decouple normalization proof from cbase32 #1717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bb1e4ed
basen: decouple normalization proof from cbase32
sergey-shandar Aug 26, 2026
01330c2
basen: strengthen normalized miss proof
sergey-shandar Aug 26, 2026
0d5dab8
Merge branch 'main' into codex/fix-an-important-open-issue-from-todo-…
sergey-shandar Aug 26, 2026
535c5cb
Merge branch 'main' into codex/fix-an-important-open-issue-from-todo-…
sergey-shandar Aug 26, 2026
6dc219c
Merge branch 'main' into codex/fix-an-important-open-issue-from-todo-…
sergey-shandar Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 8 additions & 16 deletions fjs/basen/proof.f.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,10 @@ import { baseN } from './module.f.mjs'

const hex = baseN(4n, '0123456789abcdef')

const cb32 = baseN(5n, '0123456789abcdefghjkmnpqrstvwxyz', c => {
const lower = c.toLowerCase()
switch (lower) {
case 'i': { return '1' }
case 'l': { return '1' }
case 'o': { return '0' }
default: { return lower }
}
})
// A synthetic normalizer keeps this proof focused on `baseN`'s mechanism
// rather than duplicating the rules owned by a concrete codec.
const normalizedHex = baseN(4n, '0123456789abcdef', c =>
c === 'x' ? 'a' : c === 'y' ? 'z' : c.toLowerCase())

// Sample input for the `big` proof below: 262 144 `f` characters decode into a
// 1 Mibit (`maxLength`) vector.
Expand Down Expand Up @@ -48,16 +43,13 @@ export const proof = {
},
normalizeHit: () => {
// 'A' lowercases to 'a' — same vector as the lowercase input.
const a = cb32.stringToVec('A')
const b = cb32.stringToVec('a')
const a = normalizedHex.stringToVec('A')
const b = normalizedHex.stringToVec('a')
assertEq(a, b, [a, b])
// Crockford folds: i,l → 1 and o → 0.
assertEq(cb32.stringToVec('I'), cb32.stringToVec('1'), 'I→1')
assertEq(cb32.stringToVec('l'), cb32.stringToVec('1'), 'l→1')
assertEq(cb32.stringToVec('o'), cb32.stringToVec('0'), 'o→0')
assertEq(normalizedHex.stringToVec('x'), a, 'x→a')
},
normalizeMiss: () => {
assertEq(cb32.stringToVec('u'), null, 'unknown char should return null')
assertEq(normalizedHex.stringToVec('y'), null, 'normalizing to an unknown char should return null')
},
// Decodes a 1 Mibit hex string. With the O(n log n) `listToVec` builder this
// runs in well under a second (was ~13 s node / ~43 s bun under the old
Expand Down
57 changes: 0 additions & 57 deletions fjs/basen/todo/proof-crockford-copy.md
View file
Open in desktop

This file was deleted.

Loading