ci: bump nixpkgs snapshot to f4f69867 - #1715
Conversation
nixos-26.05 channel moved to f4f698677b11; the Node versions it provides (22.23.2, 24.19.0, 26.7.0) are unchanged, so only the flakes' pinned commit moves. All other pinned images, tool versions, and action versions checked and already current.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7f787e9155
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
functionalscript | fc8e993 | Commit Preview URL Branch Preview URL |
Aug 26 2026, 02:10 PM |
o2alexanderfedin
left a comment
There was a problem hiding this comment.
The change itself is clean. Regeneration is genuine — running the generator at head leaves the tree untouched, so the three flakes are byte-identical to generator output and nothing was hand-edited. The diff is the hash and only the hash: four one-line hunks, no reformatting, no Node version string, no input or output change. No stale copies — grepping the tree for the old hash returns zero occurrences.
I verified the version-invariance claim rather than taking it: nix isn't available here, so I read pkgs/development/web/nodejs/v{22,24,26}.nix at both pins — 22.23.2 / 24.19.0 / 26.7.0 at each. Also worth noting CI enforces it independently: the nix-flakes job asserts the exact version strings, so a wrong claim would fail rather than slip through.
f4f69867 is real, dated 2026-08-25, and is exactly the current nixos-26.05 channel revision — channels.nixos.org/nixos-26.05/git-revision returns that SHA. The old pin is a strict ancestor on the same branch, 75 commits and about two days back. No channel crossing.
Two convention items, both in the PR metadata:
The title has no <topic>: prefix. CONTRIBUTING.md:170-184 wants <topic>: <short description>, and the squash lands as <PR title> (#NNN) — the same section says not to fix it in the merge box, so it has to change here. Your own branch commit already has the right form (ci: bump nixpkgs snapshot). ci: bump nixpkgs snapshot to f4f69867 fits well inside the 72-char limit.
Trailer order is inverted. The body runs prose → bare session link → Changelog: none, but Changelog: has to be the last section before the trailer block, and session links are part of that block. Swap the last two. Content is right — a build-tooling pin bump changes no behaviour, and correctly no changelog/unreleased/1715.md was added. No duplicate trailers this time.
Gates: npm test 3393/0, tsc --noEmit exit 0, .github/ untouched (correctly — the workflow embeds the Node versions, not the nixpkgs hash, and pins no nixpkgs of its own).
o2alexanderfedin
left a comment
There was a problem hiding this comment.
Approving. Both findings are fixed — the title is now ci: bump nixpkgs snapshot to f4f69867 and conforms, and Changelog: none sits last before the session link. No duplicate trailers.
The delta is merge-only: the PR's own four files are byte-identical at both heads, and a110f069e..fc8e99359 is still exactly +4/−4. Since main brought in #1710, I re-ran the generator at the merged head — tree stays clean, so the merge didn't invalidate generated output. Four hunks are still only the hash; old hash still has zero occurrences anywhere. npm test 3396/0 (+3 = #1710's three new cbase32 proofs), tsc --noEmit exit 0.
Summary
Updates the nixpkgs reference from commit
a3b98866tof4f69867across the configuration and generated Nix flake files.Changes
fjs/ci/config/module.f.mjs)Details
This change updates the pinned nixpkgs version to a newer commit within the
nixos-26.05channel, ensuring all development environments use a consistent and up-to-date set of packages. The Node.js versions the new snapshot provides (22.23.2, 24.19.0, 26.7.0) are unchanged, so no other files are affected.Changelog: none
https://claude.ai/code/session_01WzLK5Tj6CPZzwnzsRTcCxR