Skip to content

ci: bump functionalscript bootstrap version and nixpkgs snapshot - #1621

Merged
sergey-shandar merged 3 commits into
mainfrom
claude/busy-hopper-f93jhz
Aug 16, 2026
Merged

ci: bump functionalscript bootstrap version and nixpkgs snapshot#1621
sergey-shandar merged 3 commits into
mainfrom
claude/busy-hopper-f93jhz

Conversation

@sergey-shandar

@sergey-shandar sergey-shandar commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR updates the FunctionalScript dependency to version 0.45.0 across all CI workflows and configuration files, along with updating the nixpkgs commit reference.

Key Changes

  • FunctionalScript version bump: Updated from 0.44.0 to 0.45.0 in:

    • CI workflow configuration (.github/workflows/ci.yml) - 11 occurrences across npm, deno, and bun package managers
    • Module configuration (fjs/ci/config/module.f.mjs)
  • Nixpkgs update: Updated the nixpkgs commit reference from 9f78f44a87948854445dae0b6bf82b2e87e4efb5 to 02e08985a27c65ffd33d434eeb2e660a2e4dc84d in:

    • Module configuration (fjs/ci/config/module.f.mjs)
    • Generated Nix flake files for Node.js 22, 24, and 26

Implementation Details

The changes ensure consistency across all CI environments (npm, deno, bun) and development shells by using the same FunctionalScript version and nixpkgs commit throughout the project configuration.

Changelog: none

https://claude.ai/code/session_01KRZ9i3sKgJShU8ssvqUs9b

npm's functionalscript moved to 0.45.0, and the nixos-26.05 channel
advanced to a newer commit (Node versions it provides are unchanged).
Regenerated CI workflow and Nix flakes via `npm run ci-update`.
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
functionalscript b89eb30 Commit Preview URL

Branch Preview URL
Aug 16 2026, 03:07 PM

@sergey-shandar
sergey-shandar marked this pull request as ready for review August 16, 2026 14:09
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@o2alexanderfedin o2alexanderfedin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pins are all correct — the findings are in the title and body, which become the squash commit.

No Changelog: section in the description. CONTRIBUTING.md:201 and AGENTS.md:88 make it mandatory either way. A CI pin bump changes no behavior or public API, so Changelog: none is the right content — and correspondingly no entry file, which this PR correctly doesn't add.

Title isn't <topic>: <short description>. "Upgrade FunctionalScript to 0.45.0 and update nixpkgs" — no topic prefix, no colon (CONTRIBUTING.md:178). The branch commit acc1800 is already phrased correctly (ci: bump functionalscript bootstrap version and nixpkgs snapshot), but the squash discards it.

Minor: the body says the version appears in "10 occurrences" in ci.yml; it's 11 (six npm install -g, two deno, two bun, and one more npm at line 444).

Pins verified:

  • functionalscript@0.45.0 is published and is latest. Released from this repo — 8804e78 0.45.0 (#1555), 2026-08-14. package.json also reads 0.45.0, but that's the release commit bumping it to the released version, so the "don't tie it to the in-repo version" rule is respected in substance rather than violated.
  • Ran the real bootstrap rather than trusting registry metadata: installed 0.45.0 globally into a temp prefix and ran fjs test — the exact CI command — against this branch: 2976 pass / 0 fail. Worth doing because 0.45.0 carries a **BREAKING CHANGES:** entry (#1520, the npm package ships no .js files); it doesn't affect the bootstrap path.
  • nixpkgs 02e08985… exists, compare to nixos-26.05 is identical (pin is exactly at the branch head), https://channels.nixos.org/nixos-26.05/git-revision returns that same SHA, and old→new is ahead_by: 149 so it moves forward. nodejs_22/nodejs_24/nodejs_26 all still resolve at the pinned commit.
  • npm run ci-update leaves the tree clean, so the generated ci.yml and three flakes match the config. No stale 9f78f44a anywhere. The two surviving 0.44.0 strings (fjs/ci/packed-consumer-validation.md:76,84) are pre-existing on main and untouched here.
  • npx tsc 0, fjs t 2976 pass / 0 fail, cov 100/100/100, prepack clean.

@sergey-shandar sergey-shandar changed the title Upgrade FunctionalScript to 0.45.0 and update nixpkgs ci: bump functionalscript bootstrap version and nixpkgs snapshot Aug 16, 2026

Copy link
Copy Markdown
Contributor Author

Addressed the review feedback:

  • Title changed to ci: bump functionalscript bootstrap version and nixpkgs snapshot (matches <topic>: <short description>, fits 72 chars with (#1621)).
  • Added the mandatory Changelog: none section — this PR only bumps CI pins, no behavior/public API change.
  • Fixed the occurrence count in the description (10 → 11).

No code changes were needed — all pins were confirmed correct by the review.


Generated by Claude Code

@o2alexanderfedin o2alexanderfedin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All three addressed — approving.

Title is now ci: bump functionalscript bootstrap version and nixpkgs snapshot, the body carries Changelog: none (right, since no behavior or public API changes, and correspondingly no entry file), and the count reads 11, which is what grep -c '0\.45\.0' .github/workflows/ci.yml gives.

The only new commit is the main catch-up: git diff 7194a2a3 refs/pr/1621 is just fjs/effects/todo/io-effect-consumer-migration.md arriving from #1616, and git diff origin/main refs/pr/1621 is still exactly the five expected files with only the two pin bumps. Nothing of main's is missing.

Still green at b89eb304: npx tsc 0, fjs t 2976 pass / 0 fail, cov 100/100/100, ci-update leaves the tree clean.

Pin verification from the previous pass stands: 0.45.0 is latest on npm and the real fjs test bootstrap passes against this branch, the nixpkgs commit matches what channels.nixos.org/nixos-26.05/git-revision advertises and moves forward 149 commits, and all three nodejs_* attributes resolve at it.

@sergey-shandar
sergey-shandar added this pull request to the merge queue Aug 16, 2026
Merged via the queue into main with commit f8837a4 Aug 16, 2026
19 checks passed
@sergey-shandar
sergey-shandar deleted the claude/busy-hopper-f93jhz branch August 17, 2026 05:34
@o2alexanderfedin o2alexanderfedin mentioned this pull request Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants