Skip to content

Bring asn.1 to 100% line/branch/function coverage: 90.91% → 100% branch #1596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sergey-shandar merged 2 commits into from
Aug 15, 2026
Merged

Bring asn.1 to 100% line/branch/function coverage: 90.91% → 100% branch #1596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
271afeb
Bring asn.1 to 100% line/branch/function coverage
claude Aug 15, 2026
15f7037
Add changelog entry for #1596
claude Aug 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/unreleased/1596.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- `asn.1`: adds proof coverage for `parsedTagDecode`'s tag class ×
primitive/constructed combinations, bringing the module to 100%
line/branch/function coverage
16 changes: 16 additions & 0 deletions fjs/asn.1/proof.f.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,22 @@ export const proof = {
// Re-encoding an UnsupportedRecord returns it unchanged (it is already the TLV bytes)
assertEq(encode(decoded), raw, 'encode should round-trip UnsupportedRecord')
},
// parsedTagDecode narrows the top three bits of the tag's first byte
// (class + primitive/constructed) to one of exactly eight values via an
// 8-way `||` assert. Every other test in this file only ever exercises
// the universal-primitive tag (top bits 000), so each of the other seven
// comparisons has never had a case where it's the one that turns the
// assert true — one round trip per class×P/C combination covers them all.
tagClass: {
universalPrimitive: () => check(0x02n, vec8(0x42n), empty),
universalConstructed: () => check(0x22n, vec8(0x42n), empty),
applicationPrimitive: () => check(0x42n, vec8(0x42n), empty),
applicationConstructed: () => check(0x62n, vec8(0x42n), empty),
contextPrimitive: () => check(0x82n, vec8(0x42n), empty),
contextConstructed: () => check(0xA2n, vec8(0x42n), empty),
privatePrimitive: () => check(0xC2n, vec8(0x42n), empty),
privateConstructed: () => check(0xE2n, vec8(0x42n), empty),
},
raw: [
() => {
const e = encodeRaw([0x00n, vec8(0x23n)])
Expand Down
Loading