Skip to content

Add proof test for JSON tokenizer minus state EOF handling #1549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sergey-shandar merged 3 commits into from
Aug 14, 2026
Merged

Add proof test for JSON tokenizer minus state EOF handling #1549

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32904d3
media/json/tokenizer: cover parseMinusState's EOF branch directly
claude Aug 14, 2026
9644525
Merge branch 'main' into claude/zen-archimedes-5s54pp
claude Aug 14, 2026
fe928fa
Merge branch 'main' into claude/zen-archimedes-5s54pp
sergey-shandar Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion fjs/media/json/tokenizer/module.f.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,10 @@
* @import { JsonToken, _ScanState, _ScanInput } from './types.ts'
*/

import { concat, empty, flat, stateScan } from '../../../types/list/module.f.mjs'
import { concat, empty, flat, stateScan, toArray } from '../../../types/list/module.f.mjs'
import { multiply } from '../../../types/bigfloat/module.f.mjs'
import { tokenize as jsTokenize } from '../../../js/tokenizer/module.f.mjs'
import { assertEq } from '../../../asserts/module.f.mjs'

/** @type {(input: JsToken) => List<JsonToken>} */
const mapToken = input => {
Expand Down Expand Up @@ -76,3 +77,20 @@ export const tokenize = input => {
const jsTokens = jsTokenize(input)('')
return flat(stateScan(scanToken)({ kind: 'def' })(concat(jsTokens)([null])))
}

export const proof = {
// `parseMinusState` only sees `null` if the JSON tokenizer's own EOF
// sentinel arrives while still in state '-' — i.e. input ends right after
// a lone `-`. Unreachable through the public `tokenize`: the underlying
// JS tokenizer always emits its own `eof` token first, and consuming that
// (the default branch, any kind other than '-' or 'number') resets state
// to 'def' before the sentinel `null` is ever seen. Call the private
// state handler directly to cover the branch anyway.
parseMinusStateEof: () => {
const [tokens, state] = parseMinusState(null)
assertEq(state.kind, 'def')
const a = toArray(tokens)
assertEq(a.length, 1)
assertEq(a[0].kind, 'error')
},
}
Loading