-
-
Notifications
You must be signed in to change notification settings - Fork 6
Migrate fjs/ci/nix to .f.mjs #1493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
390c402
Migrate fjs/ci/nix to .f.mjs, split NixJob type into types.ts
claude 55f1424
Add CHANGELOG entry for fjs/ci/nix migration (#1493)
claude b078d73
Migrate fjs/ci/node to .f.mjs
claude 5c07521
Migrate fjs/ci/module.f.ts to .f.mjs, split Setup type into types.ts
claude e8c7b1c
Migrate fjs/media/type to .f.mjs
claude 23423a7
Merge branch 'main' into claude/convert-f-ts-to-f-mjs-13
sergey-shandar f0430f8
Fix stale .f.ts references in fjs/ci/README.md
claude a085863
Merge remote-tracking branch to include upstream main merge
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| /** | ||
| * Types for generated CI Nix flakes. | ||
| * | ||
| * @module | ||
| */ | ||
|
|
||
| /** A CI job's development environment, one generated flake each. */ | ||
| export type NixJob = { | ||
| /** Generated directory name under `nix/generated`, matching the CI job id. */ | ||
| readonly id: string | ||
| /** Nix system of the job's runner, e.g. `aarch64-linux`. */ | ||
| readonly system: string | ||
| /** Nixpkgs attribute names made available in the job's shell. */ | ||
| readonly packages: readonly string[] | ||
| /** Job-local shell initialization, when the job needs one. */ | ||
| readonly shellHook?: string | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After these modules move to
.f.mjsandSetupmoves totypes.ts,fjs/ci/README.md:10-22,45-46still directs readers to the deletedmodule.f.ts,node/module.f.ts, andnix/module.f.tsfiles and omits the new type companion. Anyone following the repository's primary CI documentation therefore reaches nonexistent paths; update those entries as part of the migration.Useful? React with 👍 / 👎.