Rename private JSDoc typedefs in migrated modules - #1462

Approving. This closes the gap I'd been raising, and it improves on what I asked for.

You were right to push back on my list. My audit derived privacy mechanically from whether the pre-migration TypeScript alias was exported. Keeping Fn, NotLazy, Empty and Concat public because they're genuinely part of those modules' vocabulary is the better call — export status in the old .ts records what the implementation happened to need, not what consumers should have. Saying so explicitly in fjs/fsc/README.md is the part that makes it stick; otherwise the next audit re-derives my rule and re-opens it.

You also caught three I'd missed entirely — Revision in bit_vec, and TupleX / IndexX in array. The latter two never existed in the .ts at all (they're helpers introduced by the migration itself), so a diff against pre-migration exports would never have surfaced them.

Verified

Renames are complete in both directions:

old names importable from the migrated modules : 9 errors  (all gone)
_Norm _NormOp _Base _UnpackConcat _ListToVecState _ListToVecOp _Revision _Tuple _Index : all resolve
Fn NotLazy Empty Concat : still public, as intended

npx tsc clean, npm test → pass: 2354, fail: 0, total: 2354.

Omitting **BREAKING CHANGES:** is correct, and for a stronger reason than "the expanded types are unchanged." I checked whether these names were ever reachable by a consumer: both the fjs/types/array (#1454) and fjs/types/bit_vec (#1460) migrations are still under ## Unreleased, above the ## 0.43.1 header, and 0.43.1 is the published version. So the un-prefixed aliases have never appeared in a released package — there is no consumer who could have imported Base or Norm to break. The visibility leak is being closed inside the same unreleased window that opened it, which is the cleanest possible time to do it.

Deleting todo/rename-private-jsdoc-typedefs.md once the work is done follows the repo's delete-when-done rule.

One trivial leftover

fjs/common/monoid/todo/balanced-fold.md lines 101 and 118 still refer to the Accumulator / ListToVecState bookkeeping by the old name. Prose in a todo about eventually deleting that machinery, so nothing depends on it — just the kind of thing the "sweep prose references to already-migrated modules" task in migrate-typescript-to-mjs.md is there to catch. Not worth a commit on its own.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8dac64c0cc

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e0b2b44932