Skip to content

Don't checkout master in roll_dev - #54150

Merged
tvolkert merged 1 commit into
flutter:masterfrom
tvolkert:roll_dev
Apr 6, 2020
Merged

tvolkert merged 1 commit into
flutter:masterfrom
tvolkert:roll_dev

Conversation

@tvolkert

@tvolkert tvolkert commented Apr 6, 2020

Copy link
Copy Markdown
Contributor

Description

It interferes with the existence of release branches.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Apr 6, 2020
@fluttergithubbot

Copy link
Copy Markdown
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@tvolkert
tvolkert requested review from Hixie and cbracken April 6, 2020 23:13

@cbracken cbracken left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

@tvolkert
tvolkert merged commit de1e572 into flutter:master Apr 6, 2020
@tvolkert
tvolkert deleted the roll_dev branch April 6, 2020 23:15
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants