Fixing start_at, end_at, equal_to queries to accept False values#96
Merged
Conversation
avishalom
suggested changes
Nov 28, 2017
Contributor
avishalom
left a comment
avishalom
left a comment
There was a problem hiding this comment.
Delete the "empty" from the doc string
| @@ -444,8 +444,8 @@ def start_at(self, start): | |||
| Raises: | |||
| ValueError: If the value is empty or None. | |||
Contributor
There was a problem hiding this comment.
If empty is ok, amend comments here and below
Contributor
Author
There was a problem hiding this comment.
Done. Good catch.
avishalom
approved these changes
Nov 30, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
start_at(),end_at()andequal_to()method in theQueryclass currently does not acceptFalseas a valid argument (along with a bunch of other false values such as empty string and empty dict). This PR relaxes the argument checks so these values are supported.Resolves #88. Related to #89.