Skip to content

Selection vector improve - #1061

Merged
kushalkolar merged 12 commits into
ndwidgetfrom
selection_vector_improve
Aug 6, 2026
Merged

Selection vector improve#1061
kushalkolar merged 12 commits into
ndwidgetfrom
selection_vector_improve

Conversation

@apasarkar

@apasarkar apasarkar commented Jun 11, 2026 •
edited by kushalkolar
Loading

Copy link
Copy Markdown
Collaborator

closes #1047.

Concrete changes:

  • Includes logic to block re-entrance when selections are changed
  • Includes more compact code for adding selectors to make things more declarative. Now the user just provides the selector + a global index --> local index mapping. This mapping is given by a 1D array (or a dictionary). The inverse mapping and event handler logic is dealt with internally within SelectionVector.
  • Fills in missing functionality: clear selectables, remove, remove_selector

@apasarkar
apasarkar marked this pull request as draft June 11, 2026 05:16
kushalkolar
kushalkolar requested changes Jun 12, 2026
View reviewed changes
Comment thread fastplotlib/graphics/selectors/_highlight_selector.py Outdated
Comment thread fastplotlib/graphics/selectors/_selection_vector.py Outdated
Comment thread fastplotlib/graphics/selectors/_selection_vector.py Outdated
Comment thread fastplotlib/graphics/selectors/_selection_vector.py Outdated
Comment thread fastplotlib/graphics/selectors/_selection_vector.py Outdated
Comment thread fastplotlib/graphics/selectors/_selection_vector.py Outdated
Comment thread fastplotlib/graphics/selectors/_selection_vector.py Outdated
Comment thread fastplotlib/graphics/selectors/_selection_vector.py
kushalkolar
kushalkolar requested changes Aug 4, 2026
View reviewed changes
Comment thread fastplotlib/graphics/selectors/_selection_vector.py Outdated
Comment thread fastplotlib/graphics/selectors/_selection_vector.py Outdated
kushalkolar
kushalkolar requested changes Aug 4, 2026
View reviewed changes
Comment thread fastplotlib/graphics/selectors/_selection_vector.py
Comment thread fastplotlib/graphics/selectors/_selection_vector.py
kushalkolar
kushalkolar reviewed Aug 4, 2026
View reviewed changes
Comment thread fastplotlib/graphics/selectors/_selection_vector.py Outdated
@kushalkolar
kushalkolar marked this pull request as ready for review August 4, 2026 19:26
@kushalkolar
kushalkolar merged commit 852c0a2 into ndwidget Aug 6, 2026
@kushalkolar
kushalkolar deleted the selection_vector_improve branch August 6, 2026 20:58
@kushalkolar kushalkolar mentioned this pull request Aug 7, 2026
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kushalkolar kushalkolar kushalkolar approved these changes
@clewis7 clewis7 Awaiting requested review from clewis7 clewis7 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@apasarkar @kushalkolar