Collect information about screen resolution #35
Open
alexbruy wants to merge 5 commits intoexplodingcamera:mainfrom
Open
Collect information about screen resolution #35alexbruy wants to merge 5 commits intoexplodingcamera:mainfrom
alexbruy wants to merge 5 commits intoexplodingcamera:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently Liwan only distinguish between desktop and mobile clients, and does not provide any insight on the visitor's screen sizes/resolution. Knowing most used screen size for instance can help with defining breakpoints and creating optimized images.
In this PR I tried to add support for screen size tracking. I'm new to Rust, so my code probably not that good.
Also, as I have no experience with Astro and TS, Gemini helped me to understand which changes are necessary on the frontend (dashboard) side. I hope I got them right.