v0.5.0 prep - READY FOR MERGE#21
Conversation
I'm not sure this *was* working in Python 3.1, but TravisCI isn't testing it and Tox coughs up an `ImportError: No module named ssl_match_hostname`. We can look into this more, but supporting 3.1 probably isn't worth it.
Good practice and Python 3.2/3.3 had this to say, `embedly\client.py:152: ResourceWarning: unclosed <socket.socket object, ...>`
…lejson` because we don't support Python 2.5.
Mostly this updates the `Url` model documentation to reflect its more pythonic nature as a true dictionary. Also update a couple links, don't use `sudo` and fix the RST formatting for a few code blocks.
|
I'm in the middle of increasing test coverage. Once that's ready I think 0.5.0 is done. Thoughts? |
|
Looks great. I do believe that we need to make this work on Python 3, but a target of 3.3 would be nice. Thanks for all your work here. |
|
Python 3.2 and 3.3 are easy. I mean you guys already did that work =) |
|
Nice! |
(This now matches the response decoding already used in `_get()`. It was never noticed because tests didn't cover it.)
This may be overkill but it does increase test coverage and if we develop more fine-grained tests for `_get()` in the future, mock will help.
It doesn't make a ton of changes in truth, but it's a recommended step on the conversion path. It does handle the `urllib` path though!
…the test dependencies
Also test for it, which increases test coverage to 100%.
|
More stuff, namely test coverage is at 100% and I took a hard look at Python 3. I believe some things were previously broken under Python 3 but escaped notice because the test coverage was incomplete.
That certainly isn't an all encompassing scenario, but it's what I expected. So all that's solved and there's a test for it. |
|
I'm declaring this done. Would love another set of eyes and tests though. |
|
It looks good to me, merge away! |
Updates and fixes necessary for an official release.
A previous PR (one of mine) broke testing in Python 2.6 and the Readme needed a refresh. This also officially drops Python 3.1 support.
Other new things
setup.py testis available (and used by TravisCI)setup.pyuses2to3conversion during the build process for Python 3mockis used in tests