Skip to content

Fix merging dicts for duplicate dotted keys - #46

Merged
basepi merged 9 commits into
elastic:masterfrom
basepi:duplicatedottedkeys45
Jul 1, 2021
Merged

Fix merging dicts for duplicate dotted keys#46
basepi merged 9 commits into
elastic:masterfrom
basepi:duplicatedottedkeys45

Conversation

@basepi

@basepi basepi commented Jun 29, 2021

Copy link
Copy Markdown
Contributor

Fixes #45

@ghost

ghost commented Jun 29, 2021

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #46 updated

  • Start Time: 2021-07-01T14:58:16.403+0000

  • Duration: 7 min 23 sec

  • Commit: 54c5afc

Test stats 🧪

Test Results
Failed 0
Passed 235
Skipped 11
Total 246

Trends 🧪

Image of Build Times

Image of Tests

Comment thread tests/test_structlog_formatter.py
@basepi
basepi requested a review from sethmlarson June 30, 2021 18:22
Comment thread ecs_logging/_utils.py Outdated
Comment thread CHANGELOG.md Outdated

@sethmlarson sethmlarson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple comments, like this approach much better!

Comment thread tests/test_apm.py Outdated
Comment thread tests/conftest.py
@basepi
basepi requested a review from sethmlarson July 1, 2021 14:57

@sethmlarson sethmlarson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

@basepi
basepi merged commit 850c9cb into elastic:master Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StructlogFormatter throws TypeError with duplicated dotted keys

2 participants