Skip to content

Switch preview to chunked transfer - #921

Merged
nik9000 merged 1 commit into
elastic:masterfrom
nik9000:smaller_node
Jul 9, 2019
Merged

Switch preview to chunked transfer#921
nik9000 merged 1 commit into
elastic:masterfrom
nik9000:smaller_node

Conversation

@nik9000

@nik9000 nik9000 commented Jun 6, 2019

Copy link
Copy Markdown
Member

Switches the PR preview infrastructure from buffering the entire file to
chunked transfer. This allows us to do two things:

  1. Shrink the size of the node process significantly.
  2. Handle large files.

Switches the PR preview infrastructure from buffering the entire file to
chunked transfer. This allows us to do two things:
1. Shrink the size of the node process significantly.
2. Handle large files.
@nik9000
nik9000 requested a review from haywoood June 6, 2019 20:24
@nik9000

nik9000 commented Jul 8, 2019

Copy link
Copy Markdown
Member Author

@haywoood, could you have a look at this one?

@haywoood haywoood left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@nik9000
nik9000 merged commit 5b6c8c3 into elastic:master Jul 9, 2019
@nik9000

nik9000 commented Jul 9, 2019

Copy link
Copy Markdown
Member Author

Thanks for reviewing @haywoood!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants