Fix out-of-bounds access in setFunctionCode()#412
Merged
Miq1 merged 1 commit intoJun 5, 2025
Conversation
The setFunctionCode() method incorrectly uses reserve() instead of resize() to prepare the vector MM_data for writing at indices 0 and 1. reserve() only allocates memory but does not change the vector size, so accessing MM_data[0] or MM_data[1] causes undefined behavior when the vector is empty or too small. This commit changes reserve() to resize() to ensure valid indices exist before writing to MM_data, preventing out-of-bounds writes and potential crashes.
Contributor
|
Your observation is correct, I missed the point that using There are more spots where I used |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The setFunctionCode() method incorrectly uses reserve() instead of resize() to prepare the vector MM_data for writing at indices 0 and 1.
reserve() only allocates memory but does not change the vector size, so accessing MM_data[0] or MM_data[1] causes undefined behavior when the vector is empty or too small.
This commit changes reserve() to resize() to ensure valid indices exist before writing to MM_data, preventing out-of-bounds writes and potential crashes.