Use tskNO_AFFINITY instead of NULL in xTaskCreatePinnedToCore#411
Merged
Miq1 merged 2 commits intoMay 18, 2025
Conversation
Contributor
|
Thanks a lot - missed that up to now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According espressif documentation, if you don't want to pin a task to a core, you should use tskNO_AFFINITY .
Looking at the logic in ModbusClientTCP::begin , I expect this is what was intended. Anyways, with tskNO_AFFINITY I get better performance fro my usecase where my esp32 acts as a master to read from a TCP device and after conversion serves this back out over RTU .