Reworked PR #739 (multiple tags)#835
Merged
KostyaSha merged 1 commit intodocker-java:masterfrom May 5, 2017
Merged
Conversation
Closed
Codecov Report
@@ Coverage Diff @@
## master #835 +/- ##
==========================================
+ Coverage 71.75% 71.82% +0.06%
==========================================
Files 306 306
Lines 6596 6629 +33
Branches 486 497 +11
==========================================
+ Hits 4733 4761 +28
- Misses 1577 1579 +2
- Partials 286 289 +3
Continue to review full report at Codecov.
|
Member
Author
|
Reviewed 7 of 7 files at r1. Comments from Reviewable |
orzeh
suggested changes
Apr 27, 2017
| webTarget = webTarget.queryParam("t", command.getTag()); | ||
|
|
||
| if (command.getTags() != null && !command.getTags().isEmpty()) { | ||
| webTarget = webTarget.queryParam("t", command.getTags()); |
Contributor
There was a problem hiding this comment.
should be:
webTarget = webTarget.queryParamSet("t", command.getTags());| if (command.getTags() != null && !command.getTags().isEmpty()) { | ||
| webTarget = webTarget.queryParam("t", command.getTags()); | ||
| } else if (command.getTags() != null) { | ||
| webTarget = webTarget.queryParamsSet("t", command.getTags()); |
Contributor
There was a problem hiding this comment.
should be:
webTarget = webTarget.queryParam("t", command.getTag());
Member
Author
|
@orzeh please review again |
Several tags for image can be defined by calling multiple time withTag() method of BuildImageCmd. In Netty implementation, the WebTarget class is modified to support several query parameteres with the same name. Fix docker-java#720
Contributor
|
@KostyaSha LGTM 👍 |
KostyaSha
commented
May 11, 2017
| if (command.getTags() != null && !command.getTags().isEmpty()) { | ||
| webTarget = webTarget.queryParamsSet("t", command.getTags()); | ||
| } else if (isNotBlank(command.getTag())) { | ||
| webTarget = webTarget.queryParam("t", command.getTags()); |
panuse
pushed a commit
to TuKangTech/docker-java
that referenced
this pull request
Aug 20, 2017
Reworked PR docker-java#739 (multiple tags)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reworked #739
@orzeh please review
This change is