Fix it by KostyaSha · Pull Request #620 · docker-java/docker-java

KostyaSha · 2016-06-29T21:50:58Z

trying fix ITs with mass changes
closes #491

This change is

com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException: Unrecognized field "username" (class com.github.dockerjava.api.model.AuthConfig), not marked as ignorable (0 known properties: ]) at [Source: { "username": "jdoe", "password": "secret", "email": "jdoe@acme.com" }

This reverts commit 3c9a2ce.

KostyaSha · 2016-07-04T07:50:04Z

src/main/java/com/github/dockerjava/jaxrs/async/AbstractCallbackNotifier.java


-        try {
-            InputStream inputStream = new WrappedResponseInputStream(response);
+        try (InputStream inputStream = new WrappedResponseInputStream(response)) {


@marcuslinke resource leak fix

KostyaSha · 2016-07-04T07:57:03Z

@marcuslinke i tried upgrade to jersey version that contains fix for your issue, but got

deleteDockerContainerImage(com.github.dockerjava.netty.exec.AttachContainerCmdExecTest)  Time elapsed: 0.326 sec  <<< FAILURE!
javax.ws.rs.ProcessingException: java.lang.IllegalStateException: Connection pool shut down
Caused by: java.lang.IllegalStateException: Connection pool shut down

Have you seen this error before?

marcuslinke · 2016-07-04T18:22:19Z

@KostyaSha No, haven't seen this before. Will try to reproduce locally...

KostyaSha · 2016-07-04T18:22:59Z

@marcuslinke i see a lot of different fails (jersey, hijack, connection pool), trying to split everything to small portions now.

KostyaSha · 2016-07-04T18:52:36Z

$ export DOCKER_HOST="unix:///var/run/docker.sock"
$ export DOCKER_VERSION="1.11.2-0~trusty"

Tests run: 358, Failures: 7, Errors: 0, Skipped: 57, Time elapsed: 480.982 sec <<< FAILURE! - in TestSuite
(com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest)  Time elapsed: 0.378 sec  <<< FAILURE!
javax.ws.rs.ProcessingException: Error closing message content input stream.
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.assertFileCopied(CopyArchiveToContainerCmdImplTest.java:83)
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.copyFileToContainer(CopyArchiveToContainerCmdImplTest.java:57)
Caused by: java.io.IOException: Bad file descriptor at Socket[addr=0.0.0.0/0.0.0.0,port=0,localport=0][fd=java.io.FileDescriptor@3284854a; file=/run/docker.sock; connected=false; bound=false]
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.assertFileCopied(CopyArchiveToContainerCmdImplTest.java:83)
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.copyFileToContainer(CopyArchiveToContainerCmdImplTest.java:57)
Caused by: org.newsclub.net.unix.AFUNIXSocketException: Bad file descriptor
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.assertFileCopied(CopyArchiveToContainerCmdImplTest.java:83)
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.copyFileToContainer(CopyArchiveToContainerCmdImplTest.java:57)
(com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest)  Time elapsed: 0.376 sec  <<< FAILURE!
javax.ws.rs.ProcessingException: Error closing message content input stream.
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.assertFileCopied(CopyArchiveToContainerCmdImplTest.java:83)
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.copyStreamToContainer(CopyArchiveToContainerCmdImplTest.java:66)
Caused by: java.io.IOException: Bad file descriptor at Socket[addr=0.0.0.0/0.0.0.0,port=0,localport=0][fd=java.io.FileDescriptor@7bf6d56d; file=/run/docker.sock; connected=false; bound=false]
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.assertFileCopied(CopyArchiveToContainerCmdImplTest.java:83)
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.copyStreamToContainer(CopyArchiveToContainerCmdImplTest.java:66)
Caused by: org.newsclub.net.unix.AFUNIXSocketException: Bad file descriptor
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.assertFileCopied(CopyArchiveToContainerCmdImplTest.java:83)
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.copyStreamToContainer(CopyArchiveToContainerCmdImplTest.java:66)
(com.github.dockerjava.core.command.StatsCmdImplTest)  Time elapsed: 4.166 sec  <<< FAILURE!
javax.ws.rs.ProcessingException: Error closing message content input stream.
    at com.github.dockerjava.core.command.StatsCmdImplTest.testStatsStreaming(StatsCmdImplTest.java:73)
Caused by: java.io.IOException: Bad file descriptor at Socket[addr=0.0.0.0/0.0.0.0,port=0,localport=0][fd=java.io.FileDescriptor@7f51b0f0; file=/run/docker.sock; connected=false; bound=false]
    at com.github.dockerjava.core.command.StatsCmdImplTest.testStatsStreaming(StatsCmdImplTest.java:73)
Caused by: org.newsclub.net.unix.AFUNIXSocketException: Bad file descriptor
    at com.github.dockerjava.core.command.StatsCmdImplTest.testStatsStreaming(StatsCmdImplTest.java:73)
(com.github.dockerjava.core.command.EventsCmdImplTest)  Time elapsed: 19.434 sec  <<< FAILURE!
javax.ws.rs.ProcessingException: Error closing message content input stream.
    at com.github.dockerjava.core.command.EventsCmdImplTest.testEventStreaming1(EventsCmdImplTest.java:87)
Caused by: java.io.IOException: Bad file descriptor at Socket[addr=0.0.0.0/0.0.0.0,port=0,localport=0][fd=java.io.FileDescriptor@19733990; file=/run/docker.sock; connected=false; bound=false]
    at com.github.dockerjava.core.command.EventsCmdImplTest.testEventStreaming1(EventsCmdImplTest.java:87)
Caused by: org.newsclub.net.unix.AFUNIXSocketException: Bad file descriptor
    at com.github.dockerjava.core.command.EventsCmdImplTest.testEventStreaming1(EventsCmdImplTest.java:87)
(com.github.dockerjava.core.command.EventsCmdImplTest)  Time elapsed: 20.436 sec  <<< FAILURE!
javax.ws.rs.ProcessingException: Error closing message content input stream.
    at com.github.dockerjava.core.command.EventsCmdImplTest.testEventStreaming2(EventsCmdImplTest.java:105)
Caused by: java.io.IOException: Bad file descriptor at Socket[addr=0.0.0.0/0.0.0.0,port=0,localport=0][fd=java.io.FileDescriptor@55a266b2; file=/run/docker.sock; connected=false; bound=false]
    at com.github.dockerjava.core.command.EventsCmdImplTest.testEventStreaming2(EventsCmdImplTest.java:105)
Caused by: org.newsclub.net.unix.AFUNIXSocketException: Bad file descriptor
    at com.github.dockerjava.core.command.EventsCmdImplTest.testEventStreaming2(EventsCmdImplTest.java:105)
(com.github.dockerjava.core.command.EventsCmdImplTest)  Time elapsed: 20.158 sec  <<< FAILURE!
javax.ws.rs.ProcessingException: Error closing message content input stream.
    at com.github.dockerjava.core.command.EventsCmdImplTest.testEventStreamingWithFilter(EventsCmdImplTest.java:121)
Caused by: java.io.IOException: Bad file descriptor at Socket[addr=0.0.0.0/0.0.0.0,port=0,localport=0][fd=java.io.FileDescriptor@79f7ec4f; file=/run/docker.sock; connected=false; bound=false]
    at com.github.dockerjava.core.command.EventsCmdImplTest.testEventStreamingWithFilter(EventsCmdImplTest.java:121)
Caused by: org.newsclub.net.unix.AFUNIXSocketException: Bad file descriptor
    at com.github.dockerjava.core.command.EventsCmdImplTest.testEventStreamingWithFilter(EventsCmdImplTest.java:121)
deleteDockerContainerImage(com.github.dockerjava.netty.exec.AttachContainerCmdExecTest)  Time elapsed: 0.338 sec  <<< FAILURE!
javax.ws.rs.ProcessingException: java.lang.IllegalStateException: Connection pool shut down
Caused by: java.lang.IllegalStateException: Connection pool shut down
Results :
Failed tests: 
com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.(com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest)
  Run 1: PASS
  Run 2: CopyArchiveToContainerCmdImplTest.copyFileToContainer:57->assertFileCopied:83 » Processing
  Run 3: PASS
  Run 4: CopyArchiveToContainerCmdImplTest.copyStreamToContainer:66->assertFileCopied:83 » Processing
  Run 5: PASS
com.github.dockerjava.core.command.EventsCmdImplTest.(com.github.dockerjava.core.command.EventsCmdImplTest)
  Run 1: PASS
  Run 2: EventsCmdImplTest.testEventStreaming1:87 » Processing Error closing message co...
  Run 3: EventsCmdImplTest.testEventStreaming2:105 » Processing Error closing message c...
  Run 4: EventsCmdImplTest.testEventStreamingWithFilter:121 » Processing Error closing ...
  StatsCmdImplTest.testStatsStreaming:73 » Processing Error closing message cont...
  AttachContainerCmdExecTest.deleteDockerContainerImage » Processing java.lang.I...
Tests run: 295, Failures: 4, Errors: 0, Skipped: 1

KostyaSha · 2016-07-04T18:58:43Z

$ export DOCKER_HOST="tcp://127.0.0.1:2375"
$ export DOCKER_VERSION="1.11.2-0~trusty"

Tests run: 358, Failures: 2, Errors: 0, Skipped: 57, Time elapsed: 480.484 sec <<< FAILURE! - in TestSuite
(com.github.dockerjava.core.command.FrameReaderITest)  Time elapsed: 0.808 sec  <<< FAILURE!
java.lang.IllegalStateException: Connection pool shut down
deleteDockerContainerImage(com.github.dockerjava.netty.exec.AttachContainerCmdExecTest)  Time elapsed: 0.326 sec  <<< FAILURE!
javax.ws.rs.ProcessingException: java.lang.IllegalStateException: Connection pool shut down
Caused by: java.lang.IllegalStateException: Connection pool shut down
Results :
Failed tests: 
com.github.dockerjava.core.command.FrameReaderITest.(com.github.dockerjava.core.command.FrameReaderITest)
  Run 1: PASS
  Run 2: FrameReaderITest.canLogInOneThreadAndExecuteCommandsInAnother » IllegalState C...
  AttachContainerCmdExecTest.deleteDockerContainerImage » Processing java.lang.I...
Tests run: 301, Failures: 2, Errors: 0, Skipped: 1

KostyaSha · 2016-07-07T18:41:13Z

One IT now green https://travis-ci.org/docker-java/docker-java/jobs/143116581 ! perfect

KostyaSha · 2016-07-07T18:42:34Z

And unix may fail because i switched deps...

KostyaSha · 2016-07-07T21:06:19Z

@marcuslinke don't worry i will make clean PR, in process..

KostyaSha · 2016-07-12T08:35:50Z

Everything beside junix socket update was merged. closing.

KostyaSha added 17 commits June 20, 2016 14:55

Try debug auth issues.

21b0a10

Fix travis build vs docker-toolbox.

b11e3fe

Fix resource leak

7eeeae7

Try update jersey.

df6004f

Update all deps

b155c28

update all deps

a6697fc

update all deps

615580a

revert version

cd769b4

drop deps

a2735c2

add junit

8f37bcf

don't print hash

e481c2e

Fix tests

c42f3dc

save restored

3c9a2ce

Revert "save restored"

b7862dc

This reverts commit 3c9a2ce.

revert versions

34b8ad9

use latest working

2fb8742

KostyaSha reviewed Jul 4, 2016
View reviewed changes

This was referenced Jul 4, 2016

Start Container Constructs Incorrect POST #615

Closed

Fix it2 #621

Merged

This was referenced Jul 7, 2016

Fix: Second execution of a docker command in Netty implementation always fails #630

Merged

[CID-125822] Fix resource leak #622

Merged

Fix connection pool shutdown when garbage collection runs

f37c48c

marcuslinke force-pushed the fixIT branch from 64da99a to f37c48c Compare July 7, 2016 20:57

KostyaSha mentioned this pull request Jul 7, 2016

Fix it rebase #631

Merged

KostyaSha closed this Jul 12, 2016

KostyaSha deleted the fixIT branch September 28, 2016 23:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix it#620

Fix it#620
KostyaSha wants to merge 18 commits intomasterfrom
fixIT

KostyaSha commented Jun 29, 2016 •

edited

Loading

Uh oh!

KostyaSha Jul 4, 2016

Uh oh!

KostyaSha commented Jul 4, 2016

Uh oh!

marcuslinke commented Jul 4, 2016

Uh oh!

KostyaSha commented Jul 4, 2016 •

edited

Loading

Uh oh!

KostyaSha commented Jul 4, 2016 •

edited

Loading

Uh oh!

KostyaSha commented Jul 4, 2016

Uh oh!

KostyaSha commented Jul 7, 2016

Uh oh!

KostyaSha commented Jul 7, 2016

Uh oh!

KostyaSha commented Jul 7, 2016

Uh oh!

KostyaSha commented Jul 12, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

KostyaSha commented Jun 29, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KostyaSha Jul 4, 2016

Choose a reason for hiding this comment

Uh oh!

KostyaSha commented Jul 4, 2016

Uh oh!

marcuslinke commented Jul 4, 2016

Uh oh!

KostyaSha commented Jul 4, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KostyaSha commented Jul 4, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KostyaSha commented Jul 4, 2016

Uh oh!

KostyaSha commented Jul 7, 2016

Uh oh!

KostyaSha commented Jul 7, 2016

Uh oh!

KostyaSha commented Jul 7, 2016

Uh oh!

KostyaSha commented Jul 12, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

KostyaSha commented Jun 29, 2016 •

edited

Loading

KostyaSha commented Jul 4, 2016 •

edited

Loading

KostyaSha commented Jul 4, 2016 •

edited

Loading