Implemented Device parser#593
Merged
marcuslinke merged 2 commits intodocker-java:masterfrom Jun 8, 2016
Merged
Conversation
Current coverage is 30.29%
@@ master #593 diff @@
==========================================
Files 296 296
Lines 6218 6245 +27
Methods 0 0
Messages 0 0
Branches 547 553 +6
==========================================
+ Hits 1420 1892 +472
+ Misses 4706 4353 -353
+ Partials 92 0 -92
|
KostyaSha
force-pushed
the
deviceParser
branch
2 times, most recently
from
5df54bf to
a3880ed
Compare
Member
Author
|
Todo implement validator, but i have no time and daemon error would return error. |
Member
Author
|
@marcuslinke please review |
Signed-off-by: Kanstantsin Shautsou <kanstantsin.sha@gmail.com>
| * @link https://github.com/docker/docker/blob/6b4a46f28266031ce1a1315f17fb69113a06efe1/runconfig/opts/parse.go#L796 | ||
| */ | ||
| private static boolean validDeviceMode(String deviceMode) { | ||
| Map<String, Boolean> validModes = new HashMap<>(3); |
Contributor
There was a problem hiding this comment.
The `validModes' map should be declared as static member and not declared inline.
Member
Author
There was a problem hiding this comment.
what do you mean under not declared inline.?
Contributor
There was a problem hiding this comment.
I mean it should be declared at the class level not in the method itself.
Member
Author
There was a problem hiding this comment.
It must be mutable, it changes true to false to exclude double letters.
Member
Author
|
@marcuslinke updated, feel free to squash merge (dropdown in merge button) if it LGTY. |
panuse
pushed a commit
to TuKangTech/docker-java
that referenced
this pull request
Aug 20, 2017
* Implement Device parser Signed-off-by: Kanstantsin Shautsou <kanstantsin.sha@gmail.com> * Add more tests, fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #592
This change is