ENH: add warning message when qmax > pi / rstep in PDFCalculator#31
Open
st3107 wants to merge 1 commit into
Open
ENH: add warning message when qmax > pi / rstep in PDFCalculator#31st3107 wants to merge 1 commit into
st3107 wants to merge 1 commit into
Conversation
Author
|
Sometime wrong with the build process. Need to change the scon file. This should be in another PR. |
Contributor
|
should I wait to review?
…On Tue, Oct 26, 2021 at 3:15 PM Songsheng Tao ***@***.***> wrote:
Sometime wrong with the build process. Need to change the scon file. This
should be in another PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#31 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAOWULIPQ5RHUPURXXK66DUI344HANCNFSM5GYN4S5Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
Simon Billinge
Professor, Columbia University
Physicist, Brookhaven National Laboratory
|
Author
|
Yes. This is not a simple issue. It is related to the scon build. I need
some time to figure it out.
On Tue, Oct 26, 2021 at 3:40 PM Simon Billinge ***@***.***>
wrote:
… should I wait to review?
On Tue, Oct 26, 2021 at 3:15 PM Songsheng Tao ***@***.***>
wrote:
> Sometime wrong with the build process. Need to change the scon file. This
> should be in another PR.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#31 (comment)>, or
> unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/ABAOWULIPQ5RHUPURXXK66DUI344HANCNFSM5GYN4S5Q
>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
>
> or Android
> <
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
>.
>
>
--
Simon Billinge
Professor, Columbia University
Physicist, Brookhaven National Laboratory
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#31 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI27ND4HANXNZLYL2HGFREDUI37ZNANCNFSM5GYN4S5Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
[image: photo]
*Songsheng Tao*
Ph. D. student, Columbia University
347-749-7947
Create your own email signature
<https://www.wisestamp.com/create-own-signature/?utm_source=promotion&utm_medium=signature&utm_campaign=create_your_own&srcid=>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sbillinge I added the warning message. Refer to the this issue.