Cookierelease: setup src folder structure#10
Merged
Conversation
bobleesj
commented
Aug 11, 2024
| """Run NMF analysis on PDF and XRD data""" | ||
|
|
||
| # package version | ||
| from diffpy.nmf_mapping.version import __version__ |
bobleesj
commented
Aug 11, 2024
| from sklearn.decomposition import NMF, PCA | ||
| from sklearn.exceptions import ConvergenceWarning | ||
|
|
||
| from diffpy.utils.parsers.loaddata import loadData |
Contributor
Author
There was a problem hiding this comment.
done by pre-commit
| # obtain version information | ||
| from importlib.metadata import version | ||
|
|
||
| __version__ = version("diffpy.nmf_mapping") |
sbillinge
reviewed
Aug 12, 2024
sbillinge
left a comment
sbillinge
left a comment
Contributor
There was a problem hiding this comment.
this looks good. It is failing precommit for what may be a typo in run.py but I am not sure. Tests are now running. Since this is mostly moving files, I am ok merging this and then debugging on the next PR, but it is showing as a draft PR indicating that you don't want me to merge it yet. Just let me know.
Contributor
Author
|
@sbillinge Yes, Please merge. I will look into the details ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.