Skip to content

Move tests folder#99

Merged
sbillinge merged 6 commits into
diffpy:mainfrom
yucongalicechen:move-tests
Sep 13, 2024
Merged

Move tests folder#99
sbillinge merged 6 commits into
diffpy:mainfrom
yucongalicechen:move-tests

Conversation

@yucongalicechen

Copy link
Copy Markdown
Collaborator

closes #98

@bobleesj

bobleesj commented Sep 9, 2024

Copy link
Copy Markdown
Contributor

@yucongalicechen

The CI fails because the installed package is unable to find example data.

Please add a line MANIFEST.in to import the test data as well.

From

recursive-exclude * __pycache__

to

recursive-include src/diffpy/labpdfproc/data *
recursive-exclude * __pycache__

@bobleesj

bobleesj commented Sep 9, 2024

Copy link
Copy Markdown
Contributor

So, to mimic the CI behavior, you can run pytest -vv after pip install . instead of pip install -e ..

If you use pip install ., you can confirm that the you are running the tests from the installed package located in miniconda3, etc.

@yucongalicechen

Copy link
Copy Markdown
Collaborator Author

thanks for the comment! @bobleesj

@bobleesj

Copy link
Copy Markdown
Contributor

@yucongalicechen Just a quick heads up that we might do a quick re-cookiecutter for all diffpy projects we have all the issues addressed here: https://github.com/Billingegroup/cookiecutter/milestone/6

Since all the tests are running smoothly at the top directory level, it will be very easy!

@yucongalicechen

Copy link
Copy Markdown
Collaborator Author

I'm adding back labpdfproc command here because I notice it disappears again on our main branch, but I remembered adding it back in one of the previous PRs... not sure what happened.
@sbillinge I think this PR is ready for review, thanks!

@sbillinge sbillinge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. We should be able to delete init.py from the tests folder. Please can you delete that and see if everything still passes?

Then I think it is ready, it looks good.

@yucongalicechen

Copy link
Copy Markdown
Collaborator Author

Deleted! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move tests folder at the root of the repo

3 participants