Conversation
|
LGTM 👍 |
Owner
Author
|
Thanks for the review, @abrauchli! |
Signed-off-by: Danilo Bargen <mail@dbrgn.ch>
Owner
Author
|
@abrauchli may/should I add you to the commit message as This is the commit that I'm going to submit: 4760882be20d54a15ff9f2ab708ef47ff57df855 |
Owner
Author
|
And @rnestler too in case you reviewed the entire patch :) |
|
@dbrgn thanks, yes, please add |
The current driver uses clock stretching (hold master) mode to retrieve the measurements. This blocks the bus and may cause problems on some systems like the BCM2835 (Raspberry Pi) that have buggy I2C hardware¹. ¹ http://www.advamation.com/knowhow/raspberrypi/rpi-i2c-bug.html Signed-off-by: Danilo Bargen <mail@dbrgn.ch> Reviewed-by: Andreas Brauchli <andreas.brauchli@sensirion.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current driver uses clock stretching (hold master) mode to retrieve
the measurements. This blocks the bus and may cause problems on some
systems like the BCM2835 (Raspberry Pi) that have buggy I2C
implementations¹.
¹ http://www.advamation.com/knowhow/raspberrypi/rpi-i2c-bug.html