Migrate away from unittest and adopt pytest#978
Conversation
|
Appveyor fail looks unrelated. LGTM. |
|
@jpurviance Can you rebase this and the other PRs against master? I've fixed the Appveyor issue in #982. |
jpurviance
force-pushed
the
utils-pytest
branch
from
d88c48a to
38f17ae
Compare
pganssle
left a comment
pganssle
left a comment
There was a problem hiding this comment.
The content looks good to me, though I'd prefer if the commit message were cleaner.
I skimmed this article and it seems to roughly correspond to my preferred Git style.
I think you'll need to rebase after #990 anyway, so if you don't mind also adjusting the commit message to something like, "Migrate from unittest to pytest for test_utils".
At some point we should probably have a section on a good commit message and clean commit histories in the CONTRIBUTING.rst, since historically I've just manually adjusted the commit histories to my liking as part of the merge.
pganssle
left a comment
pganssle
left a comment
There was a problem hiding this comment.
Oh, one other note - this should have a changelog, changelog.d/978.misc.rst.
It's not a public-facing change, but I like to mention this stuff in the changelogs for distro maintainers.
Part of a series of commit that is moving the suite.
mariocj89
changed the title
4 participants
Summary of changes
Closes #976
Pull Request Checklist