Fix join error in the new query parser (#857)#878
Merged
guzman-raphael merged 20 commits intodatajoint:devfrom Mar 17, 2021
Merged
Fix join error in the new query parser (#857)#878guzman-raphael merged 20 commits intodatajoint:devfrom
guzman-raphael merged 20 commits intodatajoint:devfrom
Conversation
fix datajoint#828 Used static image from shields.io; slack doesn't seem to have native support for 'badges', and other solutions ( slackin ) are nice in providing a activity count, but require running a service gateway. In any event, it's a href that works (for now).
README.md: flip gitter badge to slack (datajoint#828)
Add test for same secondary attributes between dependent tables
dimitri-yatsenko
changed the title
guzman-raphael
requested changes
Mar 17, 2021
Collaborator
guzman-raphael
left a comment
guzman-raphael
left a comment
There was a problem hiding this comment.
We also need to:
- Update the
CHANGELOG.mdandReleases_lang1.rstfor this. It is really for us to be able to easily track down when bugs were patched and features introduced. - Update
nginximage to newdatajointone. - Bump the version so we can make a new pre-release.
To make things easier, let me introduce a PR to your branch with the above included.
Comment on lines
+252
to
+254
| need_subquery1 = need_subquery2 = bool( | ||
| (set(self.original_heading.names) & set(other.original_heading.names)) | ||
| - join_attributes) |
Collaborator
There was a problem hiding this comment.
This is a reasonable way to solve it with a subquery for special case. Still not a big fan of this as opposed to indexing it properly but we discussed this already. This is probably the best option given our current time constraints. We can always revisit if there is a more specific need to do so.
tests/test_fetch.py
Outdated
| assert_equal(k1, k2) | ||
|
|
||
| def test_same_secondary_attribute(self): | ||
| print(schema.Child * schema.Parent().proj()) |
Collaborator
There was a problem hiding this comment.
We need a better check here than just a simple print. Perhaps something that confirms the correct value is fetched.
Update `test_same_secondary_attribute` test + PR review feedback
guzman-raphael
approved these changes
Mar 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #857.
Fix issue #876.