suppress C++-only categories on C file extensions - #318
Merged
Conversation
".h" files don't, because many C++ headers also use this extension
Member
Author
|
Also note that the VLC test sample conflicts with #319. |
cclauss
approved these changes
Mar 4, 2025
Co-authored-by: Christian Clauss <cclauss@me.com>
Member
|
Rebase needed. |
Co-authored-by: Christian Clauss <cclauss@me.com>
cclauss
reviewed
Mar 6, 2025
Member
Author
|
Indeed. I feel like it'd be better if we just fast-tracked the next release with 3.8 support and then drop 3.8 support and merge this, though.
|
Member
|
When this is rebased, the py3.8 tests will pass. |
Member
Author
|
wrong button lol. The tests will pass when we rebase after we drop 3.8. |
Member
Author
|
Since we did use type annotations after all with the mypy PR, this should now be merge-ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
".h" files don't, because many C++ headers also use this extension
Closes #71