Fix inclusion of HunterGate.cmake#5
Merged
bkotzz merged 1 commit intocpp-pm:masterfrom Nov 6, 2019
Merged
Conversation
Member
|
Can you provide some evidence of testing so that we know this will work as expected? Maybe try running the example from the GitHub issue that flagged this? |
bkotzz
approved these changes
Nov 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4 was fixing the inclusion of the file, but that was the wrong place to fix it.
In my original code at the top of the file I had a
file(DOWNLOADstatement, which I wrongly replaced withinclude(cmake/HunterGate.Yesterday I didn't have the time to test #4. Today I've tested my gate fork and it works as expect.
cpp-pm/hunter#56 (comment) had the right suggestion, and I somehow didn't see it.